finding ESPTOOL

[mixmix]

On my computer, I discovered that ESPTOOL was not getting set correctly in loramesh/Makefile

Looking closer, I saw that the find was failing... and this was due to ESPTOOL_EXT getting set incorrectly.

I commented out this line and could then flash:

# OS=$(shell uname;)
# ifneq ($(OS), Darwin)
#   ESPTOOL_EXT=.py
# endif

My system

Ubuntu Linux

In case the version of the CLI makes a difference:

$ arduino-cli version
arduino-cli  Version: 1.2.0 Commit: 9c495211 Date: 2025-02-24T15:57:30Z

Here's what I hacked around manually to confirm what worked on my system. I show the path so others on other versions of CLI + different OS can compare:

$ find ~/.arduino15/packages/esp32/tools -name "esptool"
/home/___/.arduino15/packages/esp32/tools/esptool_py/4.9.dev3/esptool

NOTE: not esptool.py here (that was what ESPTOOL_EXT what changing my thing to search for I think)

[mixmix]

idea: if ESPTOOL is not found... then I think we should throw a nice error (I got some random error totally unrelated down the way because esptool some other argument got promoted to the executable 🔥 )

[mixmix]

idea: just spam the search!

pseudocode:

if no ESPTOOL then ESPTOOL = find "esptool"        // allow env tool to be provided?!
if no ESPTOOL then ESPTOOL = find "esptool_py"
if no ESPTOOL then ESPTOOL = find "esptool.py"
if no ESPTOOL then throw "unable to find esptool, please provide an env var ESPTOOL"

[nanomonkey]

I added a pull request that should fix this issue, as well as catch a couple of other missing components. Not sure if @tschudin will have time to review it. Perhaps @mixmix can do so instead.

[KevinTriplett]

@mixmix was this issue closed by @nanomonkey 's PR? Have you had a chance to review and test it?