v0.11: Windows: Indicate not supported

[brentyates]

On windows, I'm getting the message "Indicate not supported" when I try to enable notifications. My app works perfect in version 0.10 though, and it works perfectly on Mac.

I believe the issue is found in this PR: #293.

I would be willing to create a PR, but I would like someone to confirm... is the logic backwards on this line: https://github.com/tinygo-org/bluetooth/pull/293/files#diff-e1b3874210bb210694f1b08b334139427db8fe34db0a573d298ca0f701094781R377.

I can do more investigation to determine if my characteristic is actually using notify or indicate in this scenario. Without further investigation though, I think the logic should be checking if the property is non zero instead of zero, and same with the line 2 lines further down, it should again be checking if the GattCharacteristicPropertiesIndicate is non zero and using indicate if it is?

I will follow up with more debugging later this week.

[deadprogram]

Perhaps @jagobagascon can clarify this?

[jagobagascon]

Yes, 100% we should be checking for a non-zero value. This is the if before that change:

bluetooth/gattc_windows.go

Lines 408 to 412 in 8503b6b

	if c.properties&genericattributeprofile.GattCharacteristicPropertiesNotify != 0 {
	writeOp, err = c.characteristic.WriteClientCharacteristicConfigurationDescriptorAsync(genericattributeprofile.GattClientCharacteristicConfigurationDescriptorValueNotify)
	} else {
	writeOp, err = c.characteristic.WriteClientCharacteristicConfigurationDescriptorAsync(genericattributeprofile.GattClientCharacteristicConfigurationDescriptorValueIndicate)
	}

[deadprogram]

Labeled to close this issue after next release.