Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add env FASTLANE_PASSWORD and reindent close #7 #8

Closed
wants to merge 1 commit into from

Conversation

felipe-augusto
Copy link

  • Add possibility of setting FASTLANE_PASSWORD as env variable
  • Reindent

Please, review this to make sure I did this correctly.
This should close #7

@tkohout
Copy link
Owner

tkohout commented Oct 31, 2017

Hi Felipe,
thanks for the contribution. Fastlane plugins have built-in system for passing arguments from ENV or command line. Advantage is that users can list these arguments and see what they can pass to every action. If you want to add the password to the plugin you can add it as:

FastlaneCore::ConfigItem.new(key: :password,
                                     env_name: "FIREBASE_PASSWORD",
                                     sensitive: true,
                                     description: "Password to your firebase account",
                                     optional: true),

in here

and to the rest of the actions.

In every action you will need to get it from params and pass it to the login function as an optional parameter. Also, please do not re-indent the files, we might need to do some proper indentation in future but I would rather do it all at once.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use ENV or input password as a alternative to prompt
2 participants