-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Disable nightly features for wasm build #524
Comments
Can I take this issue? |
@danilowhk , hi. We would appreciate if you did. Let's make sure this is just a research stage. You could look into it and then document the available paths forward in this issue. |
Hey @themighty1 , sounds good! Will do some research on it and share a doc here |
For tlsn-js it seems that the only dependency requiring nightly is wasm-bindegen-rayon These are the compiler features that require nightly:
But currently, it is not possible to compile `wasm-bindgen-rayon without the atomics feature, as it will give a compiler error: The recommendation from the
|
Currently when building tlsn for wasm targets we are forced to use a nightly compiler due to
wasm-bindgen-rayon
requiring it (see https://github.com/RReverser/wasm-bindgen-rayon/?tab=readme-ov-file#building-rust-code)The adverse effect of using the nightly compiler is that it activates experimental features which may cause tlsn dependencies to use those features, making the wasm build susceptible to bugs caused by the experimental features.
The solution is to determine which compiler features are nightly-only and to disable those features for the wasm build.
The text was updated successfully, but these errors were encountered: