You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
In my current project, there is a strict requirement to have go v1.21 while later versions like v1.22 are not allowed. The only change needed is go 1.22.0 => go 1.21.0 in go.mod file. I tried locally and it works fine.
Also in my project, I need to load Markdown files with extension .mdx (rather than .md) while the content format is the same. To support this extension just need to change condition filepath.Ext(file.Name()) != ".md" to (filepath.Ext(file.Name()) != ".md" && filepath.Ext(file.Name()) != ".mdx") in documentloaders/notion.go
These changes will not impact existing behavior and no regressions are expected. I already prepared these changes locally, so if you are OK with them - please give me permissions to commit/merge and I will send PR for review.
Thanks.
The text was updated successfully, but these errors were encountered:
go v1.21
while later versions like v1.22 are not allowed. The only change needed isgo 1.22.0
=>go 1.21.0
ingo.mod
file. I tried locally and it works fine..mdx
(rather than.md
) while the content format is the same. To support this extension just need to change conditionfilepath.Ext(file.Name()) != ".md"
to(filepath.Ext(file.Name()) != ".md" && filepath.Ext(file.Name()) != ".mdx")
indocumentloaders/notion.go
These changes will not impact existing behavior and no regressions are expected. I already prepared these changes locally, so if you are OK with them - please give me permissions to commit/merge and I will send PR for review.
Thanks.
The text was updated successfully, but these errors were encountered: