Skip to content

Commit 304ff40

Browse files
committed
fix(plan): Correct T2 insertion points and I7 line references
T2: Session-level pane title options insertion is alongside other session options at lines 303-309, not "around line 311". Pane-level title should be set after commands are sent (around line 535), before focus handling at line 536. I7: Stale TODOs are at lines 121 and 123 (not 121-123), since line 122 is `clear` which is a real teamocil feature.
1 parent be91f2e commit 304ff40

File tree

1 file changed

+3
-3
lines changed

1 file changed

+3
-3
lines changed

notes/plan.md

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -61,8 +61,8 @@ These libtmux APIs already exist and do NOT need changes:
6161
- **Blocker**: `WorkspaceBuilder` has no handling for pane `title` key or session-level `enable_pane_titles` / `pane_title_position` / `pane_title_format`.
6262
- **Blocks**: Pane titles (tmuxinator named pane syntax).
6363
- **Required**:
64-
1. Session-level: set `pane-border-status` and `pane-border-format` options via `session.set_option()` in `build()` (around line 311).
65-
2. Pane-level: call `pane.cmd("select-pane", "-T", title)` after pane creation in `iter_create_panes()` (around line 538). Requires L1 (libtmux `set_title()`), or can use `pane.cmd()` directly.
64+
1. Session-level: set `pane-border-status` and `pane-border-format` options via `session.set_option()` in `build()` alongside other session options (lines 303-309).
65+
2. Pane-level: call `pane.cmd("select-pane", "-T", title)` after commands are sent in `iter_create_panes()`, before focus handling (around line 535). Requires L1 (libtmux `set_title()`), or can use `pane.cmd()` directly.
6666
- **Config keys**: `enable_pane_titles: true`, `pane_title_position: top`, `pane_title_format: "..."` (session-level). `title: "my-title"` (pane-level).
6767
- **Non-breaking**: New optional config keys.
6868

@@ -193,7 +193,7 @@ Not imported but translatable (same key names in tmuxp):
193193

194194
### I7. Stale Importer TODOs
195195

196-
`importers.py:121-123` lists `with_env_var` and `cmd_separator` as TODOs, but neither exists in teamocil v1.4.2 source. These are stale references from ~2013 and should be removed.
196+
`importers.py:121,123` lists `with_env_var` and `cmd_separator` as TODOs (with `clear` at line 122 in between), but neither `with_env_var` nor `cmd_separator` exists in teamocil v1.4.2 source. These are stale references from ~2013 and should be removed.
197197

198198
## Implementation Priority
199199

0 commit comments

Comments
 (0)