Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

parser: support SQL comments #200

Open
tsatke opened this issue Jul 10, 2020 · 13 comments
Open

parser: support SQL comments #200

tsatke opened this issue Jul 10, 2020 · 13 comments
Labels
component/parser This is regarding the SQL parser feature New feature or enhancement good first issue Good for newcomers help wanted Extra attention is needed
Milestone
v0.0.1

Comments

@tsatke
Copy link
Contributor

tsatke commented Jul 10, 2020

Extend the parser so that he supports comments as specified here (https://www.sqlite.org/lang_comment.html).
@tsatke tsatke added feature New feature or enhancement help wanted Extra attention is needed good first issue Good for newcomers component/parser This is regarding the SQL parser labels Jul 10, 2020
@tsatke tsatke added this to the v0.0.1 milestone Jul 10, 2020
@Shivam010
Copy link

Hello,
I would like to grab this issue and work on it if no one is working on it.

@tsatke
Copy link
Contributor Author

tsatke commented Sep 7, 2020 •
edited
Loading

Hi, please move to xqueries/xdb and find that issue. We no longer work in this repo

xqueries/xdb#1

@tomarrell
Copy link
Owner

You're more than welcome to pick up this issue here if you'd like.

Tim has made a fork and has moved to that, however you're welcome to contribute to whichever you would like.

I'd be happy to review a PR if you open it.

@Shivam010
Copy link

Ok, but is there any particular reason for maintaining two different project works?
I am kinda confused with the parting.
Can I know the goal set or the differences between both the projects if possible, @tomarrell @tsatke?

@Shivam010
Copy link

I would really like to work on building a database. I like the project.

@tsatke
Copy link
Contributor Author

tsatke commented Sep 7, 2020

@tomarrell is inactive since about febuary, and I'm not an admin in this repo, so I can't archive it or anything

@tsatke
Copy link
Contributor Author

tsatke commented Sep 7, 2020

the goal set of the new project is just a different roadmap really

@tsatke
Copy link
Contributor Author

tsatke commented Sep 7, 2020

Let's take this discussion to xqueries/xdb#1

@Shivam010
Copy link

Shivam010 commented Sep 7, 2020 •
edited
Loading

Ok, if it's about inactivity

@tomarrell
Copy link
Owner

Sure, I have certainly been less than active, that is true. However, I would not consider this project abandoned by any means. I would consider it more of a long running project.

The goal of this project when I first embarked on it was to build something that was ultimately as simple as possible in order to act as a good reference for people who want to learn the inner workings of a distributed database.

If you share the same goals, then you're more than welcome to contribute here if you would like.

Otherwise, xqueries/xdb looks to be a good option if you would like to take it past this above goal, as it appears they're looking to build something a little more tuned for production use.

@tsatke
Copy link
Contributor Author

tsatke commented Sep 7, 2020

Yes, I would fully agree with that description! Feel free to choose either one, you're welcome in both projects!

@Shivam010
Copy link

Right now I would like to choose xdb. No hard feelings.

@tomarrell
Copy link
Owner

No worries at all. Best of luck!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
component/parser This is regarding the SQL parser feature New feature or enhancement good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Milestone
v0.0.1
Development

No branches or pull requests
3 participants
@tomarrell @Shivam010 @tsatke