Skip to content

Reviewer Management: There is no remove reviewer button for an assigned reviewer #1031

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jmgasper opened this issue Apr 15, 2025 · 11 comments

Comments

@jmgasper
Copy link
Collaborator

jmgasper commented Apr 15, 2025

REF: https://topcoder.atlassian.net/browse/PM-929

There is no remove reviewer button for an assigned reviewer

We can implement this to remove the reviewer via the resources API, similar to the user management functionality.

Image
@phead198708
Copy link

hey, @jmgasper i can't find related service to deassign the reviewer. Could you pls check ?

@jmgasper
Copy link
Collaborator Author

@phead198708 - To deassign a reviewer, we will just remove them as a reviewer via the resources API, similar to what we do on the Manage Users tab

Image

@phead198708
Copy link

we dont' know the role id in review application page, so we can't delete the resource directly (role id is required).

How about redirect to user management page ? then user can remove reviewer there.

@jmgasper
Copy link
Collaborator Author

Yes, that would be fine.

@jmgasper
Copy link
Collaborator Author

jmgasper commented Apr 30, 2025

@phead198708 - Check https://system-admin.topcoder-dev.com/review-management/30096645/manage-reviewer.

This one seems off, there are approved reviewers, but no remove reviewer button.

Image

@phead198708
Copy link

fixed on feat/system-admin branch

Image

@jmgasper
Copy link
Collaborator Author

It is still not directing to the correct manage user tab.

Steps to reproduce:

  • Click the Review Management.
    
  • Click a challenge (goes to challenge details page) and note down the challenge Id. Ex: For DS sc, challenge id: 01671c1c-08d5-42f7-b600-3b254edb8ff4
    
  • Then click the “Manage Reviewers” button of that particular challenge.
    
  • Click “Remove reviewer” button for the approved reviewer.
    
  • Observe the redirection to the Challenge Management → Manage User’s page.
    

Expected result:

The redirection on clicking the “Remove reviewer” button should be to the correct challenge’s manage user’s page. Ex: https://system-admin.topcoder-dev.com/challenge-management/01671c1c-08d5-42f7-b600-3b254edb8ff4/manage-user

Actual result:

The redirection on clicking the “Remove reviewer” button is by default going to https://system-admin.topcoder-dev.com/challenge-management/c713e250-ecb4-4192-8717-d607ddda8db4/manage-user

@jmgasper
Copy link
Collaborator Author

From QA:

Now, even after removing the reviewer from the challenge, the reviewer is still displayed in the Review management page with “Remove Reviewer” button.

Reviewer “Mariokranities” is removed from the challenge but it is still there in the review management page of that particular challenge.

Image

Reviewer “Mariokranities” is not present in the Manage user’s page

Image

bandicam.2025-05-14.13-01-38-863.mp4

Expected result:

The reviewer removed from the challenge should not be displayed in the review management page of the challenge.

@phead198708
Copy link

hmm, actually, the review management page shows the applications of the reviewer.

Or we can move the remove reviewer button to the top of the table ? if user want to remove the approved application, then we can add a button called 'remove application' at the end of the row.

@jmgasper
Copy link
Collaborator Author

Let me think on this - I don't want it to be more confusing.

@jmgasper
Copy link
Collaborator Author

@phead198708 - For now, let's just add a "User Management" button at the top of the page that takes the user to the correct resources page for that particular challenge.

We'll remove the Remove Reviewer button functionality

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants