[InitDictPersDiagram base] correction, deleting temp2 and directly push_back

Keanu Sisouk · Keanu Sisouk · commit 2abf2b16e830 · 2023-10-20T14:26:42.000+02:00
diff --git a/core/base/initDictPersistenceDiagram/InitDictPersistenceDiagram.cpp b/core/base/initDictPersistenceDiagram/InitDictPersistenceDiagram.cpp
@@ -40,14 +40,12 @@ void InitDictPersistenceDiagram::execute(
 
   int FirstId = std::min_element(tempDistsSummed.begin(), tempDistsSummed.end())
                 - tempDistsSummed.begin();
-  const auto &temp = datas[indices[FirstId]];
-  DictDiagrams.push_back(temp);
+  DictDiagrams.push_back(datas[indices[FirstId]]);
   for(int i = 0; i < nbAtoms; ++i) {
     if(i == FirstId) {
       continue;
     } else {
-      const auto &temp2 = datas[indices[i]];
-      DictDiagrams.push_back(temp2);
+      DictDiagrams.push_back(datas[indices[i]]);
     }
   }
 }

Original file line number	Diff line number	Diff line change
`@@ -40,14 +40,12 @@ void InitDictPersistenceDiagram::execute(`
`40`	`40`
`41`	`41`	`int FirstId = std::min_element(tempDistsSummed.begin(), tempDistsSummed.end())`
`42`	`42`	`- tempDistsSummed.begin();`
`43`		`- const auto &temp = datas[indices[FirstId]];`
`44`		`- DictDiagrams.push_back(temp);`
	`43`	`+ DictDiagrams.push_back(datas[indices[FirstId]]);`
`45`	`44`	`for(int i = 0; i < nbAtoms; ++i) {`
`46`	`45`	`if(i == FirstId) {`
`47`	`46`	`continue;`
`48`	`47`	`} else {`
`49`		`- const auto &temp2 = datas[indices[i]];`
`50`		`- DictDiagrams.push_back(temp2);`
	`48`	`+ DictDiagrams.push_back(datas[indices[i]]);`
`51`	`49`	`}`
`52`	`50`	`}`
`53`	`51`	`}`