fixed clang static analyzer warning

Author: thom-dani

core/base/separatrixStability/SeparatrixStability.cpp

@@ -390,7 +390,12 @@ int ttk::SeparatrixStability::buildOccurenceArrays(
     &matchingArraySeparatrixForEachBlock) {
 
   int n_blocks = adjacencyMatrices.size();
-  int status;
+  if(n_blocks < 2) {
+    this->printErr(
+      "At least two datasets are required to perform calculations.");
+    return 0;
+  }
+  int status{};
   for(int i = 0; i < n_blocks; i++) {
     matchingArraySeparatrixForEachBlock[i].resize(n_blocks);
     for(int j = 0; j < n_blocks; j++) {

core/vtk/ttkSeparatrixStability/ttkSeparatrixStability.cpp

@@ -237,7 +237,7 @@ int ttkSeparatrixStability::execute(
   vtkMultiBlockDataSet *&multiBlock1_Separatrices,
   vtkMultiBlockDataSet *&output1_Separatrices) {
 
-  int status;
+  int status{};
   int n_blocks = multiBlock1_Separatrices->GetNumberOfBlocks();
   std::vector<std::vector<int>> LocalToGlobal(n_blocks);
   std::vector<GraphMatrixFull> adjacencyMatricesFull(n_blocks);
@@ -320,15 +320,6 @@ int ttkSeparatrixStability::execute(
     idCount++;
   }
 
-  for(int i = 0; i < n_blocks; i++) {
-    for(int j = 0; j < n_blocks; j++) {
-      assert(globalDestinationPointIdForEachBlock[i].size()
-             == matchingArrayForEachBlockDestination[j][i].size());
-      assert(globalSourcePointIdForEachBlock[i].size()
-             == matchingArrayForEachBlockSource[j][i].size());
-    }
-  }
-
 #ifdef TTK_ENABLE_OPENMP
 #pragma omp parallel for num_threads(threadNumber_)
 #endif // TTK_ENABLE_OPENMP