refactor: Improve test coverage by removing unreachable defensive code in determineCurrentOverlayId (#201)

wo-o29 · jungpaeng · web-flow · commit 697f3898ddd9 · 2025-10-13T00:18:45.000+09:00
* refactor: remove unreachable defensive code in determineCurrentOverlayId

* Refactor to improve test coverage in overlay logic

Removed unreachable defensive code to enhance test coverage.

---------

Co-authored-by: Yongbeen Im &lt;meis1541@naver.com&gt;
Co-authored-by: Yongbeen Im &lt;been.im@toss.im&gt;
diff --git a/.changeset/tiny-beers-joke.md b/.changeset/tiny-beers-joke.md
@@ -0,0 +1,5 @@
+---
+"overlay-kit": patch
+---
+
+refactor: Improve test coverage by removing unreachable defensive code in determineCurrentOverlayId
diff --git a/packages/src/context/reducer.ts b/packages/src/context/reducer.ts
@@ -58,7 +58,7 @@ export const determineCurrentOverlayId = (
 
   return targetIndexInOpenedList === openedOverlayOrderList.length - 1
     ? openedOverlayOrderList[targetIndexInOpenedList - 1] ?? null
-    : openedOverlayOrderList.at(-1) ?? null;
+    : openedOverlayOrderList[openedOverlayOrderList.length - 1];
 };
 
 export function overlayReducer(state: OverlayData, action: OverlayReducerAction): OverlayData {

-Original file line number
+Diff line change
@@ @@ -0,0 +1,5 @@ @@
 +---
 +"overlay-kit": patch
 +---
++
 +refactor: Improve test coverage by removing unreachable defensive code in determineCurrentOverlayId