Fixed a bug where loop reduction with an initial value with side effects repeated the side effect

Author: totalspectrum

Changelog.txt

@@ -3,6 +3,7 @@ Version 7.4.0
 - Fixed compile time calculations of QLOG and QEXP (thanks to Ada)
 - Fixed many incorrect address calculations for Spin2 ^x variables
 - Fixed parsing of large immediate addresses for inline asm call/jmp
+- Fixed a long standing bug in loop reduction
 - Improved some nucode peephole optimizations
 - Some longfill optimizations and bug fixes (thanks to Ada)
 

loops.c

@@ -713,6 +713,9 @@ doLoopStrengthReduction(LoopValueSet *initial, AST *body, AST *condition, AST *u
             if (!initEntry || (initEntry->flags & LVFLAG_CONDITIONAL) ) {
                 continue;
             }
+            if (ExprHasSideEffects(initEntry->value)) {
+                continue;
+            }
             lastAssign = FindName(&lv, entry->basename);
             if (!lastAssign) {
                 continue;