Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New: Add More Time to running session #400

Open
micahp2 opened this issue Nov 15, 2022 · 4 comments
Open

New: Add More Time to running session #400

micahp2 opened this issue Nov 15, 2022 · 4 comments
Assignees

Comments

@micahp2
Copy link
Contributor

micahp2 commented Nov 15, 2022

To allow Keepers or Circle runners to add additional time to an in-progress session, we need to create a way to put this function very near to the countdown timer in the session UI. This view will allow the Keeper to add more minutes or remove minutes, in increments of 1 minute at a time. Changes to the time take place immediately upon exiting this dialog window.

Additionally, the Keeper can choose from this same UI to end the session entirely.

An example UI can be found here: https://drive.google.com/file/d/1TILXu_E1-6S61V-KLs_1ZbCUo0d2fhPI/view?usp=share_link

@ansells ansells self-assigned this Nov 21, 2022
@ansells ansells moved this from Engineering Ready to In Progress in Next Nov 21, 2022
@ansells
Copy link
Collaborator

ansells commented Nov 22, 2022

@micahp2 If you are already in "overtime" should you be able to add time to the session? I would think not, but if you did then it would need to be added from "now" and not the session end time, right?

Also, since you say you can "remove minutes" then I assume this value can go negative, correct?

@micahp2
Copy link
Contributor Author

micahp2 commented Nov 22, 2022

@ansells here's what I would say to your questions:

  • Once in overtime you can't add more time; you can only end the session
  • You can add more time while still in the normal, scheduled session time
  • Removing minutes from the normal scheduled time shouldn't make the session time go negative; yes the input for this option would have to show negative minutes being applied to the total time

Does that help?

@ansells
Copy link
Collaborator

ansells commented Nov 22, 2022

Yep, very helpful. One last question. Once the session is in overtime should the menu button just go away? Or, perhaps we should put the "end session" as an option under that menu rather than in the dialog itself?

@micahp2
Copy link
Contributor Author

micahp2 commented Nov 22, 2022

I would switch the button to the "end session" action and show that to the Keeper. That's a better use of that space than hiding or disabling the button.

ansells added a commit that referenced this issue Nov 23, 2022
Issue #400 Add time to running session
Backend:
- Implement cloud function `addMinutesToSession`
- Fixed name of `expiresOn` field
Frontend:
- Refactor the session time into its own widget `CircleSessionTimer`
- Add menu for keeper with option to "modify time" and "end now"
- Implement dialog for adding time
- Add interfaces to call cloud function for adding time to session
@ansells ansells mentioned this issue Nov 23, 2022
@ansells ansells moved this from In Progress to In Review in Next Nov 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: In Review
Development

No branches or pull requests

2 participants