Pass TLS connection context into Request

[aep]

currently in the connection handler we just call tower_h2::Server::serve(socket)
it would be useful if there was a way to pass metadata to that call that is later available in Request
specifically i'd like to give it the client certificate

[aep]

any consensus on how that should be implemented?

i would prefer a service wouldn't be Cloned but instead reconstructed on every incoming connection with the connection passed as argument.

impl server::Greeter<C> for Greet<C> {
    pub fn new(c: C) -> Self

//..
let c: C = whateverYouWant();
let serve = h2.serve(sock, c);

[carllerche]

In general, this is what the extensions field on http::Request is for.

While manual for now, you should be able to do what you want by calling serve_modified instead: https://tower-rs.github.io/tower-h2/tower_h2/server/struct.Server.html#method.serve_modified. You then stick the certificate into the request's extension slot: https://docs.rs/http/0.1.6/http/request/struct.Request.html#method.extensions_mut

Does this work?

[olix0r]

Here's an example where we do something similar in Conduit:
https://github.com/runconduit/conduit/blob/13b33b6f3a257e8261cab599b2fc956b741636cb/proxy/src/transparency/server.rs#L187-L192

[carllerche]

I'm going to close this, but feel free to post additional questions or let me know if you think there are remaining actionable items (and I can open it again).

[aep]

this sounds great, but tower_grpc::Request does not contain the http::Request so there's no way to get the extensions out

[carllerche]

I think it would be fine to include the extensions as part of the grpc request type.

@olix0r @seanmonstar Thoughts?

[seanmonstar]

Yep, seems simple enough to stick them inside tower_grpc::Request!

[olix0r]

So, we're suggesting that grpc::Request::from_http steals http::Request's extension map? SGTM.

[carllerche]

@aep is this something you want to contribute?

[aep]

can do later :)

[olix0r]

possibly related: hyperium/hyper#1594

[carllerche]

Relates to: tower-rs/tower#108