Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Uncaught Reference error in changeset #37

Closed
JanKrotky opened this issue Jun 9, 2014 · 1 comment
Closed

Uncaught Reference error in changeset #37

JanKrotky opened this issue Jun 9, 2014 · 1 comment

Comments

@JanKrotky
Copy link

Hi, just installed the plugin into Trac 1.0.1., and the comments I add doesn't show. They are visible on Code comments tab, but not at all in the browser or changeset.

In the console is this error:

Uncaught ReferenceError: id is not defined VM2628:3

with trace pointing on the code-comments.js

(anonymous function) VM2628:3
(anonymous function) underscore-min.js:29
window.CommentView.Backbone.View.extend.render code-comments.js:48
window.CommentView.Backbone.View.extend.appendTo code-comments.js:56
window.CommentsForALineView.Backbone.View.extend.addOne code-comments.js:148
window.LineCommentsView.Backbone.View.extend.addOne code-comments.js:118
(anonymous function) code-comments.js:123
b.each.b.forEach underscore-min.js:11
e.Collection.(anonymous function) backbone-min.js:28
window.LineCommentsView.Backbone.View.extend.addAll code-comments.js:122
e.Events.trigger backbone-min.js:14
f.extend.reset backbone-min.js:24
a.success backbone-min.js:24
f.resolveWith jquery-1.5.min.js:16
w jquery-1.5.min.js:16
c jquery-1.5.min.js:16

If a new comment is written to line, the dialog doesn't close on submit, and the only thing that appears by the line is a reply button and the same error in console.

Is it just some incompatibility of versions (jquery, backbone, or trac in general)?

@JanKrotky
Copy link
Author

Sorry I didn't see that at first, but it is already fixed in #25. Confirming that adding the two lines works.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant