Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CUDA kernels names shouldn't all be "kernel" #234

Open
torsteingrindvik opened this issue Nov 6, 2024 · 0 comments
Open

CUDA kernels names shouldn't all be "kernel" #234

torsteingrindvik opened this issue Nov 6, 2024 · 0 comments

Comments

@torsteingrindvik
Copy link

Hardcoded here:

  1. https://github.com/tracel-ai/cubecl/blob/main/crates/cubecl-cuda/src/compute/server.rs#L366
  2. https://github.com/tracel-ai/cubecl/blob/main/crates/cubecl-cpp/src/shared/kernel.rs#L125

I think that perhaps either

  1. The kernel name should always be equal to the Rust name, or
  2. It should default to the Rust name but let the user name it via some API or via the proc macro (e.g. #[cube(launch, name = "foo")]

The reason for having names is that if profiling with Nsight tools we can see which kernels are which. This is diffifcult when the names are the same.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant