Improve backtrace routine

Author: ex0dus-0x

src/include/deepstate/DeepState.h

@@ -36,6 +36,7 @@
 #include <unistd.h>
 #include <fnmatch.h>
 #include <execinfo.h>
+#include <dlfcn.h>
 
 #include <deepstate/Log.h>
 #include <deepstate/Compiler.h>
@@ -59,6 +60,10 @@
 #define DEEPSTATE_SIZE 8192
 #endif
 
+#ifndef DEEPSTATE_CRASH_MAX_FRAMES
+#define DEEPSTATE_CRASH_MAX_FRAMES 63
+#endif
+
 #ifndef DEEPSTATE_MAX_SWARM_CONFIGS
 #define DEEPSTATE_MAX_SWARM_CONFIGS 1024
 #endif
@@ -526,19 +531,37 @@ extern void DeepState_SaveCrashingTest(void);
 /* Emit test function backtrace after test crashes. */
 static void DeepState_EmitBacktrace(int signum, siginfo_t *sig, void *context) {
 
-  DeepState_LogFormat(DeepState_LogInfo, "Test crashed with: %s", sys_siglist[sig->si_status]);
+  const char *result;
+  if (!sig->si_status)
+    result = sys_siglist[signum];
+  else
+    result = sys_siglist[sig->si_status];
+
+  DeepState_LogFormat(DeepState_LogInfo, "Test crashed with: %s", result);
+
+  // TODO: add line number of crash (ie. addr2line)
+
+  void *back_addrs[DEEPSTATE_CRASH_MAX_FRAMES];
+  char **symbols;
 
-  void *array[10];
   size_t size;
-  char **strings;
 
-  size = backtrace(array, 10);
-  strings = backtrace_symbols(array, size);
+  size = backtrace(back_addrs, DEEPSTATE_CRASH_MAX_FRAMES);
+  if (size == 0)
+    DeepState_Abandon("Cannot retrieve backtrace stack addresses");
+
+  symbols = backtrace_symbols(back_addrs, size);
+  if (symbols == NULL)
+    DeepState_Abandon("Cannot retrieve symbols for stack addresses");
 
+  // TODO: demangle and resolve, also do for Darwin/BSD
+
+  DeepState_LogFormat(DeepState_LogTrace, "======= Backtrace: =========");
   for (size_t i = 0; i < size; i++)
-     DeepState_LogFormat(DeepState_LogTrace, "%s", strings[i]);
+     DeepState_LogFormat(DeepState_LogTrace, "%s", symbols[i]);
+  DeepState_LogFormat(DeepState_LogTrace, "===========================");
 
-  free(strings);
+  free(symbols);
 }
 
 
@@ -714,7 +737,7 @@ static enum DeepState_TestRunResult
 DeepState_ForkAndRunTest(struct DeepState_TestInfo *test) {
 
   /* If flag is set, install a signal handler for SIGCHLD */
-  /* TODO(alan): use handler as "multiplexer" and handle child signal */
+  /* TODO(alan): use handler as robust "multiplexer" and handle child signal */
   if (FLAGS_verbose_crash_trace) {
     struct sigaction sigact, oldact;
 
@@ -724,7 +747,6 @@ DeepState_ForkAndRunTest(struct DeepState_TestInfo *test) {
     sigaction(SIGCHLD, &sigact, &oldact);
   }
 
-
   pid_t test_pid;
   if (FLAGS_fork) {
     test_pid = fork();

src/lib/DeepState.c

@@ -43,7 +43,6 @@ DEFINE_bool(abort_on_fail, ExecutionGroup, false, "Abort on file replay failure
 DEFINE_bool(exit_on_fail, ExecutionGroup, false, "Exit with status 255 on test failure.");
 DEFINE_int(min_log_level, ExecutionGroup, 0, "Minimum level of logging to output (default 2, 0=debug, 1=trace, 2=info, ...).");
 DEFINE_int(timeout, ExecutionGroup, 120, "Timeout for brute force fuzzing.");
-DEFINE_uint(num_workers, ExecutionGroup, 1, "Number of workers to spawn for testing and test generation.");
 DEFINE_bool(verbose_reads, ExecutionGroup, false, "Report on bytes being read during execution of test.");
 DEFINE_bool(verbose_crash_trace, ExecutionGroup, false, "If test crashes, report an execution backtrace after abrupt exit.");