Skip to content

enh(deps): Use packagist.org to load whilesmart libs #79

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 16, 2025
Merged

Conversation

nfebe
Copy link
Contributor

@nfebe nfebe commented Jul 16, 2025

No description provided.

nfebe added 2 commits July 16, 2025 01:04
- Also removes commands to build plugin docs as it's now included in the plugin engine

Signed-off-by: nfebe <[email protected]>
@nfebe nfebe force-pushed the feat/use-packagist branch from 3d170f6 to f48b178 Compare July 16, 2025 00:11
@nfebe nfebe marked this pull request as ready for review July 16, 2025 00:11
Copy link

sourceant bot commented Jul 16, 2025

Code Review Summary

✨ This review covers updates to composer.json and composer.lock primarily focused on refining dependency management and build processes. Key changes include the removal of custom VCS repositories, standardization of Composer branch alias syntax, and updates to dependency URLs and internal configurations in the lock file.

🚀 Key Improvements

  • Simplified composer.json by removing custom VCS repositories.
  • Standardized Composer branch alias syntax to dev-main for better clarity and compatibility.

💡 Minor Suggestions

  • Verify the impact of the openapi:plugins script removal on documentation generation workflows.
  • Confirm that the changes within composer.lock for whilesmart/laravel-plugin-engine (specifically the removal of autoload-dev and scripts sections) do not adversely affect local development or CI processes.

Copy link

@sourceant sourceant bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review complete. No specific code suggestions were generated. See the overview comment for a summary.

@nfebe nfebe merged commit 69f7593 into main Jul 16, 2025
2 checks passed
@nfebe nfebe deleted the feat/use-packagist branch July 16, 2025 00:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant