Skip to content

Simplify issuer storage #173

Merged
phbnf merged 5 commits intotransparency-dev:mainfrom
phbnf:inline
Aug 27, 2024
Merged

Simplify issuer storage #173
phbnf merged 5 commits intotransparency-dev:mainfrom
phbnf:inline

Conversation

@phbnf
Copy link
Contributor

@phbnf phbnf commented Aug 23, 2024

#88

  • Inline calls to Exists and simplify the API
  • Write directly doing a read first: we're talking about saving cents here for 15k entries, it's not worth the complexity
  • crack open the precondition errors to make sure it's really failing because of the precondition we pass

@phbnf phbnf requested a review from AlCutter August 23, 2024 14:33
@codecov-commenter
Copy link

codecov-commenter commented Aug 23, 2024

Codecov Report

Attention: Patch coverage is 0% with 31 lines in your changes missing coverage. Please review.

Project coverage is 34.52%. Comparing base (46ec9c2) to head (cb8a9e6).
Report is 84 commits behind head on main.

Files Patch % Lines
personalities/sctfe/storage.go 0.00% 25 Missing ⚠️
personalities/sctfe/storage/gcp/issuers.go 0.00% 6 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #173      +/-   ##
==========================================
- Coverage   35.80%   34.52%   -1.28%     
==========================================
  Files          16       34      +18     
  Lines        1363     2966    +1603     
==========================================
+ Hits          488     1024     +536     
- Misses        801     1831    +1030     
- Partials       74      111      +37     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@AlCutter AlCutter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a new nits mostly, and missing locking.

@phbnf phbnf merged commit 73bdb05 into transparency-dev:main Aug 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants