Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bootstrap5 compatible close buttons #191

Open
michael-schindler opened this issue Jan 19, 2022 · 0 comments
Open

Bootstrap5 compatible close buttons #191

michael-schindler opened this issue Jan 19, 2022 · 0 comments
Labels
Q&A Questions and answers

Comments

@michael-schindler
Copy link

First: The whole package works great with bootstrap5 as well. Thanks for this module! Anyways, I discovered a minor issue:

The close buttons do not work properly with bootstrap5 if I use the example provided. Instead of using the button attributes data-dismiss="modal", I had to use data-bs-dismiss="modal". Also, you can use the class .btn-close instead of using <span aria-hidden="true">&times;</span> as content.

Hope this helps. If not, please ignore.

@trco trco added the Q&A Questions and answers label Mar 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Q&A Questions and answers
Projects
None yet
Development

No branches or pull requests

2 participants