Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change "filename" and "folder" keys for helpers #127

Open
macMikey opened this issue Dec 8, 2018 · 4 comments
Open

Change "filename" and "folder" keys for helpers #127

macMikey opened this issue Dec 8, 2018 · 4 comments

Comments

@macMikey
Copy link
Contributor

macMikey commented Dec 8, 2018

The current behavior is confusing. For helpers, "filename" is a path the to the folder containing the files for a helper, and "folder" is a path pointing to a folder that contains the folders that contain helpers.
Change "filename" to "folder", and "folder" to "folder of folders" or something else that is more meaningful to n00bs (and me)

@trevordevore
Copy link
Owner

The general rule in the app.yml file is that if you are pointing to a single object then use filename and if you are pointing to a folder of objects use folder. I think of a helper as being similar to an app bundle or framework on macOS. It should be thought of as a single object that happens to be made up of many files behind the scenes. Maybe it can be thought of as being a package.

I don't think that changing filename to folder for helpers is the right approach because in all of the other sections folder is used because it is a folder of behaviors, libraries, etc. I would consider using package filename as for helpers though. That seems more descriptive.

@macMikey
Copy link
Contributor Author

macMikey commented Dec 8, 2018

something more descriptive would be less confusing. filename implies something completely different from folder. Perhaps the way to address it is to allow either folder (if it actually points to a folder) or filename in the context of filename. The current behavior is going to bite people.

@trevordevore
Copy link
Owner

I do not want to use folder to point to an individual helper as it is already used in another context. That would be confusing as well. What if path was a synonym for filename and is what we used in the docs? A path can be either a filename or folder so it would be appropriate.

@macMikey
Copy link
Contributor Author

macMikey commented Dec 9, 2018

I'm cool with path. I would leave filename in place, and just add path.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants