Inconsistent Return Codes on CLI Error

[cbadke]

Problem description

The CLI is inconsistent with whether or not it returns a non-zero result code when an error occurs during usage.

Steps to reproduce

I'm sure the problem is more wide spread than this but an example is with the files functionality.

/ # trickest --token xxxxx files get
Error: required flag(s) "file" not set
<output truncated>
/ # echo $?
1
/ # trickest --token xxxxx files get --file adf
Error: couldn't find any matches for adf
/ # echo $?
0

Expected behaviour

I would expect all scenarios where the CLI is returning an error message to also return a non-zero return code to the shell.

Environment

Docker image quay.io/trickest/trickest-cli:v1.7.5

[mhmdiaa]

Implemented a partial fix in #120.

The following commands (and all their sub-commands) now consistently return a 1 exit code for errors:

• files
• library
• tools
• scripts

I've also updated the standard API error handler, which will catch a wide range of potential errors across all commands.

The remaining sub-commands will adopt this approach in a future update as part of a larger refactor (possibly introducing more nuanced exit codes to indicate different types of errors). I'll keep the issue open in the meantime.