a perhaps unidiomatic way of using 'let else' to emphasise controlflow

Author: squell

src/visudo/mod.rs

@@ -278,24 +278,7 @@ fn edit_sudoers_file(
                 )
             })?;
 
-        if errors.is_empty() {
-            if sudo_visudo_is_allowed(sudoers, &host_name) == Some(false) {
-                writeln!(
-                    stderr,
-                    "It looks like you have removed your ability to run 'sudo visudo' again.\n"
-                )?;
-                match ask_response(
-                    b"What now? (p)roceed anyway / e(x)it without saving / (e)dit again: ",
-                    b"xep",
-                )? {
-                    b'x' => return Ok(()),
-                    b'p' => {}
-                    _ => continue,
-                }
-            }
-
-            break;
-        } else {
+        let true = errors.is_empty() else {
             writeln!(stderr, "The provided sudoers file format is not recognized or contains syntax errors. Please review:\n")?;
 
             for crate::sudoers::Error {
@@ -314,7 +297,24 @@ fn edit_sudoers_file(
                 b'x' => return Ok(()),
                 _ => continue,
             }
+        };
+
+        if sudo_visudo_is_allowed(sudoers, &host_name) == Some(false) {
+            writeln!(
+                stderr,
+                "It looks like you have removed your ability to run 'sudo visudo' again.\n"
+            )?;
+            match ask_response(
+                b"What now? (p)roceed anyway / e(x)it without saving / (e)dit again: ",
+                b"xep",
+            )? {
+                b'x' => return Ok(()),
+                b'p' => {}
+                _ => continue,
+            }
         }
+
+        break;
     }
 
     let tmp_contents = std::fs::read(tmp_path)?;