Enable templating of environment name

Author: huw0

charts/trino/README.md

@@ -48,7 +48,9 @@ Fast distributed SQL query engine for big data analytics that helps you explore
     - name: registry-credentials
   ```
 * `server.workers` - int, default: `2`
-* `server.node.environment` - string, default: `"production"`
+* `server.node.environment` - string, default: `"production"`  
+
+  [node property configuration](https://trino.io/docs/current/installation/deployment.html#node-properties) The name of the environment. All Trino nodes in a cluster must have the same environment name. The name must start with a lowercase alphanumeric character and only contain lowercase alphanumeric or underscore (_) characters. Supports templating the files' contents with `tpl`.
 * `server.node.dataDir` - string, default: `"/data/trino"`
 * `server.node.pluginDir` - string, default: `"/usr/lib/trino/plugin"`
 * `server.log.trino.level` - string, default: `"INFO"`

charts/trino/templates/_helpers.tpl

@@ -155,3 +155,10 @@ Create the secret name for the group-provider file
 {{- end }}
 {{- end }}
 {{- end }}
+
+{{/*
+Return the environment name
+*/}}
+{{- define "trino.environment" -}}
+{{- tpl .Values.server.node.environment . }}
+{{- end }}

charts/trino/templates/configmap-coordinator.yaml

@@ -9,7 +9,7 @@ metadata:
     app.kubernetes.io/component: coordinator
 data:
   node.properties: |
-    node.environment={{ .Values.server.node.environment }}
+    node.environment={{ template "trino.environment" . }}
     node.data-dir={{ .Values.server.node.dataDir }}
     plugin.dir={{ .Values.server.node.pluginDir }}
   {{- range $configValue := .Values.additionalNodeProperties }}

charts/trino/templates/configmap-worker.yaml

@@ -10,7 +10,7 @@ metadata:
     app.kubernetes.io/component: worker
 data:
   node.properties: |
-    node.environment={{ .Values.server.node.environment }}
+    node.environment={{ template "trino.environment" . }}
     node.data-dir={{ .Values.server.node.dataDir }}
     plugin.dir={{ .Values.server.node.pluginDir }}
   {{- range $configValue := .Values.additionalNodeProperties }}

charts/trino/values.yaml

@@ -40,6 +40,10 @@ imagePullSecrets: []
 server:
   workers: 2
   node:
+    # server.node.environment -- [node property configuration](https://trino.io/docs/current/installation/deployment.html#node-properties)
+    # The name of the environment. All Trino nodes in a cluster must have the same environment name. The name must
+    # start with a lowercase alphanumeric character and only contain lowercase alphanumeric or underscore (_) characters.
+    # Supports templating the files' contents with `tpl`.
     environment: production
     dataDir: /data/trino
     pluginDir: /usr/lib/trino/plugin