Skip to content

Commit fbb5413

Browse files
committed
Use a better readiness probe
Use the health check script as the readiness probe, because it also checks the response of the `/v1/info` endpoint to make sure the server actually finished starting up. This only makes sense for the readiness probe, so keep the liveness probe as-is.
1 parent 3932c8f commit fbb5413

File tree

2 files changed

+8
-10
lines changed

2 files changed

+8
-10
lines changed

charts/trino/templates/deployment-coordinator.yaml

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -172,16 +172,15 @@ spec:
172172
httpGet:
173173
path: /v1/info
174174
port: http
175-
initialDelaySeconds: {{ .Values.coordinator.livenessProbe.initialDelaySeconds | default 15 }}
175+
initialDelaySeconds: {{ .Values.coordinator.livenessProbe.initialDelaySeconds | default 30 }}
176176
periodSeconds: {{ .Values.coordinator.livenessProbe.periodSeconds | default 10 }}
177177
timeoutSeconds: {{ .Values.coordinator.livenessProbe.timeoutSeconds | default 5 }}
178178
failureThreshold: {{ .Values.coordinator.livenessProbe.failureThreshold | default 6 }}
179179
successThreshold: {{ .Values.coordinator.livenessProbe.successThreshold | default 1 }}
180180
readinessProbe:
181-
httpGet:
182-
path: /v1/info
183-
port: http
184-
initialDelaySeconds: {{ .Values.coordinator.readinessProbe.initialDelaySeconds | default 15 }}
181+
exec:
182+
command: [/usr/lib/trino/bin/health-check]
183+
initialDelaySeconds: {{ .Values.coordinator.readinessProbe.initialDelaySeconds | default 10 }}
185184
periodSeconds: {{ .Values.coordinator.readinessProbe.periodSeconds | default 10 }}
186185
timeoutSeconds: {{ .Values.coordinator.readinessProbe.timeoutSeconds | default 5 }}
187186
failureThreshold: {{ .Values.coordinator.readinessProbe.failureThreshold | default 6 }}

charts/trino/templates/deployment-worker.yaml

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -138,16 +138,15 @@ spec:
138138
httpGet:
139139
path: /v1/info
140140
port: http
141-
initialDelaySeconds: {{ .Values.worker.livenessProbe.initialDelaySeconds | default 15 }}
141+
initialDelaySeconds: {{ .Values.worker.livenessProbe.initialDelaySeconds | default 30 }}
142142
periodSeconds: {{ .Values.worker.livenessProbe.periodSeconds | default 10 }}
143143
timeoutSeconds: {{ .Values.worker.livenessProbe.timeoutSeconds | default 5 }}
144144
failureThreshold: {{ .Values.worker.livenessProbe.failureThreshold | default 6 }}
145145
successThreshold: {{ .Values.worker.livenessProbe.successThreshold | default 1 }}
146146
readinessProbe:
147-
httpGet:
148-
path: /v1/info
149-
port: http
150-
initialDelaySeconds: {{ .Values.worker.readinessProbe.initialDelaySeconds | default 15 }}
147+
exec:
148+
command: [/usr/lib/trino/bin/health-check]
149+
initialDelaySeconds: {{ .Values.worker.readinessProbe.initialDelaySeconds | default 10 }}
151150
periodSeconds: {{ .Values.worker.readinessProbe.periodSeconds | default 10 }}
152151
timeoutSeconds: {{ .Values.worker.readinessProbe.timeoutSeconds | default 5 }}
153152
failureThreshold: {{ .Values.worker.readinessProbe.failureThreshold | default 6 }}

0 commit comments

Comments
 (0)