Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ability to override image repository in test-graceful-shutdown.yaml via values.yaml #291

Open
alaturqua opened this issue Jan 20, 2025 · 4 comments

Comments

@alaturqua
Copy link
Contributor

alaturqua commented Jan 20, 2025

We are using Image Caching via Azure Container Registry to overcome pull limits on Docker Hub.

It would be nice to be able to override image repository for images used in test yamls as well.

@nineinchnick
Copy link
Member

You can set the image repo and registry in values https://trinodb.github.io/charts/charts/trino/#values
The title of this issue is confusing. Why would you need to change the image in tests?

@alaturqua
Copy link
Contributor Author

alaturqua commented Jan 20, 2025

It is pulling from bitnami/kubectl:tag.

I would like to set it to customrepo/bitnami/kubectl:tag.

Otherwise we are hitting the pull limits on docker image.

@nineinchnick
Copy link
Member

If you're running tests in a fork, can you just change it in the fork?

@nineinchnick
Copy link
Member

We talked offline and I realized the tests are shipped with the chart. If users can run them, we should use the same values for adding image repository prefix as for the main Trino image.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants