addressing sourcery-ai

Author: hashroute3

gateway-ha/src/main/java/io/trino/gateway/ha/config/ClusterSchedulerConfiguration.java

@@ -18,9 +18,13 @@
 import jakarta.annotation.Nullable;
 import jakarta.annotation.PostConstruct;
 import jakarta.annotation.PreDestroy;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
 
 public class ClusterSchedulerConfiguration
 {
+    private static final Logger log = LoggerFactory.getLogger(ClusterSchedulerConfiguration.class);
+
     private final ClusterScheduler scheduler;
 
     @Inject
@@ -45,7 +49,7 @@ public void stop()
                 scheduler.close();
             }
             catch (Exception e) {
-                // Ignore
+                log.error("Exception occurred while shutting down ClusterScheduler", e);
             }
         }
     }

gateway-ha/src/main/java/io/trino/gateway/ha/config/ScheduleConfiguration.java

@@ -16,6 +16,7 @@
 import com.fasterxml.jackson.annotation.JsonProperty;
 import io.airlift.units.Duration;
 
+import java.util.ArrayList;
 import java.util.List;
 
 import static java.util.Objects.requireNonNull;
@@ -25,7 +26,7 @@ public class ScheduleConfiguration
     private boolean enabled;
     private Duration checkInterval = new Duration(5, java.util.concurrent.TimeUnit.MINUTES);
     private String timezone = "GMT"; // Default to GMT if not specified
-    private List<ClusterSchedule> schedules;
+    private List<ClusterSchedule> schedules = new ArrayList<>();
 
     @JsonProperty
     public boolean isEnabled()

gateway-ha/src/test/java/io/trino/gateway/ha/scheduler/TestClusterScheduler.java

@@ -199,6 +199,29 @@ void testClusterNotFoundInBackendManager()
         verify(backendManager, atLeastOnce()).getBackendByName(CLUSTER_NAME);
     }
 
+    @Test
+    void testSchedulerDoesNotTriggerWhenDisabled()
+    {
+        // Setup test cluster with scheduling disabled
+        when(scheduleConfig.isEnabled()).thenReturn(false);
+        when(scheduleConfig.getTimezone()).thenReturn(TEST_TIMEZONE.toString());
+
+        // Initialize the scheduler with disabled configuration
+        scheduler = new ClusterScheduler(backendManager, scheduleConfig);
+        scheduler.start();
+
+        // Time within the cron schedule (9 AM - 5 PM)
+        ZonedDateTime testTime = ZonedDateTime.of(2025, 9, 29, 10, 0, 0, 0, TEST_TIMEZONE);
+
+        // Execute
+        scheduler.checkAndUpdateClusterStatus(testTime);
+
+        // Verify no actions are taken when scheduler is disabled
+        verify(backendManager, never()).activateBackend(anyString());
+        verify(backendManager, never()).deactivateBackend(anyString());
+        verify(backendManager, never()).getBackendByName(anyString());
+    }
+
     @Test
     void testSchedulerWithDifferentTimezones()
     {