Fix incorrect IsNull predicate for row of nulls #20209
Closed
+14
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martint
requested changes
Feb 16, 2024
| @@ -439,6 +439,15 @@ protected Object visitIsNullPredicate(IsNullPredicate node, Object context) | |||
| return new IsNullPredicate(toExpression(value, type(node.getValue()))); | |||
| } | |||
|
|
|||
| if (value instanceof SqlRow sqlRow) { | |||
There was a problem hiding this comment.
This also needs to be fixed in the code generator (io.trino.sql.gen.IsNullCodeGenerator) and IrExpressionInterpreter, and for IsNotNullPredicate in all places.
|
Let me close as a stale PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Additional context and related issues
#19444
Release notes
(x) This is not user-visible or is docs only, and no release notes are required.
( ) Release notes are required. Please propose a release note for me.
( ) Release notes are required, with the following suggested text: