Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is not normalizing in the helper functions a problem? #154

Open
brando90 opened this issue Jan 20, 2022 · 0 comments
Open

Is not normalizing in the helper functions a problem? #154

brando90 opened this issue Jan 20, 2022 · 0 comments

Comments

@brando90
Copy link

I noticed that we have this:

'transform': Compose([Resize(84), ToTensor()])

    defaults = {
        'transform': Compose([Resize(84), ToTensor()])
    }

i.e. there is no normalization e.g. using:

    normalize = transforms.Normalize(mean=[0.485, 0.456, 0.406], std=[0.229, 0.224, 0.225])

might this be a problem? I assume it might if we compare results with different papers but if we only compare results within our own paper or reproduce results with the torchmeta transform then things are fine...?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant