Fix repeated conditional when local variables in diff methods #1740
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JuanVqz
commented
Oct 11, 2023
| next if condition == BLOCK_GIVEN_CONDITION | ||
|
|
||
| result[condition].push(condition.line) | ||
| result[method.name].push(condition.line) |
Contributor
Author
There was a problem hiding this comment.
This is kind of incomplete. I'm not sure which one could be better. @troessner @mvz could you please help me out?
{s(:lvar, :charlie)=>{:bravo=>[4], :delta=>[9], :echo=>[14]}}{:bravo=>{s(:lvar, :charlie)=>[4]}, :delta=>{s(:lvar, :charlie)=>[9]}, :echo=>{s(:lvar, :charlie)=>[14]}}I edited the comment, it had a ctrl + c/v error
JuanVqz
force-pushed
the
fix_repeated_conditional_local_variable_checks
branch
from
b50a544 to
e5ba696
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There might be a lot of things broken I'm opening the PR just to have feedback, I hope that is fine.
Fixes #1455