Add max_allowed calls to FeatureEnvy smell detector #1744
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JuanVqz
force-pushed
the
add_max_allowed_calls_feature_envy_smell
branch
from
da50b56 to
6750ddc
Compare
troessner
requested changes
Oct 19, 2023
JuanVqz
force-pushed
the
add_max_allowed_calls_feature_envy_smell
branch
from
6750ddc to
f5ee59c
Compare
I'm glad this is gonna be accepted. :) Shall we update any changelog file or something to mention we are adding the |
This is adding a configuration `max_calls` key for the FeatureEnvy smell detector Fixes troessner#1535
JuanVqz
force-pushed
the
add_max_allowed_calls_feature_envy_smell
branch
from
f5ee59c to
e8a8615
Compare
|
It seems like the PR is ready to be reviewed again, I forget what is missing... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is adding a configuration
max_callskey for the FeatureEnvy smell detectorFixes #1535
I know @mvz is assigned to the issue, sorry in advance for having worked on it, just wanted to learn more about Reek.