-
Notifications
You must be signed in to change notification settings - Fork 69
Add MeTTa DAS Bus Client #944
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
# Conflicts: # Cargo.toml # lib/src/space/mod.rs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Last couple of things I missed on the previous review.
Hey @vsbogd sorry for the huge delay on this one...We finally got a version tag that exposes the necessary code for this module. |
Thanks @arturgontijo , looks good to me and I am ready to merge it. There are two alternatives:
I don't see why we cannot make it default choice (i.e. option (1)), but I would like to know your opinion on this. Option (2) can be implemented as a separate PR. For the option (2) there are two places to edit:
|
In any case after the change it is worth to check that DAS integration is a part of the Release build i.e. try building docker (see https://github.com/trueagi-io/hyperon-experimental#docker) and try releasing Python binaries locally (https://github.com/trueagi-io/hyperon-experimental/blob/main/docs/DEVELOPMENT.md#how-to-release-python-distribution-packages-locally). |
BTW probably this PR obsoletes:
@CICS-Oleg , what do you think? |
Yeah, It's definitely obsolete. |
@vsbogd I vote for making it default (as this option seems more simple then
Will do and let you know |
DO NOT MERGE IT!!! As we plan to have a tag/version of the DAS repo to use it here (currently usingmaster
)This PR adds a new built-in module called
das
that uses themetta-bus-client
rust package to send pattern matching queries to a DAS Service Bus.In order to test it, one could follow the steps from Setup DAS locally and then:
Then run the MeTTa REPL binary:
@vsbogd let me know if I'm in the right direction about adding new modules here.