assert and asserts with messages added #974
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Necr0x0Der
reviewed
Jul 12, 2025
lib/tests/test_stdlib.metta
Outdated
|
|
||
| ; next part of tests is to test if message is being output on assert failure | ||
|
|
||
| !(assertEqual (assertEqualMsg (+ 1 2) 4 "Test message") ("Test message")) |
There was a problem hiding this comment.
Do I understand correctly that (assertEqualMsg (+ 1 2) 4 "Test message") returns ("Test message")? I supposed it should return a Error expression with the given message. Otherwise, it doesn't work as an assert?
There was a problem hiding this comment.
@Necr0x0Der well currently yes. As i said in the description:
One thing about asserts with custom message. Regular assert will stop program from further interpretation on failure, but -Msg asserts won't. I'm not sure about this behavior. As an alternative, instead of just outputting custom message it could be wrapped into Error like regular output of assert. So some
!(assertEqualMsg (+ 1 2) 4 "Test message") will output (Error (assertEqualMsg (+ 1 2) 4 "Test message") "Test message") instead of just ("Test message"). What behavior is preferable?
|
@Necr0x0Der I've fixed what asserts with message returns. It looks like this currently: Is this fine? |
Looks acceptable to me. |
Necr0x0Der
approved these changes
Jul 15, 2025
vsbogd
approved these changes
Jul 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So, I've added
assertas @ngeiswei asked here , please check if it is what you've asked.I've also added some asserts with custom messages as @Necr0x0Der asked here . Please also check if it is fine with you.
One thing about asserts with custom message. Regular assert will stop program from further interpretation on failure, but -Msg asserts won't. I'm not sure about this behavior. As an alternative, instead of just outputting custom message it could be wrapped into Error like regular output of assert. So some
!(assertEqualMsg (+ 1 2) 4 "Test message")will output(Error (assertEqualMsg (+ 1 2) 4 "Test message") "Test message")instead of just ("Test message"). What behavior is preferable?