[SPARK-51547][SQL] Assign name to the error condition: _LEGACY_ERROR_TEMP_2130

### What changes were proposed in this pull request?
In the PR, I propose to rename the legacy error condition `_LEGACY_ERROR_TEMP_2130` to `INVALID_DATETIME_PATTERN.WITH_SUGGESTION`.

### Why are the changes needed?
Raising an error w/ a legacy error condition for the new feature: the TIME data type looks weird at least .

### Does this PR introduce _any_ user-facing change?
No, only if user's code depends on the error condition.

### How was this patch tested?
By running the modified test suites:
```
$ build/sbt "test:testOnly *SparkThrowableSuite"
$ build/sbt "test:testOnly *TimeFormatterSuite"
$ build/sbt "sql/testOnly org.apache.spark.sql.SQLQueryTestSuite"
```

### Was this patch authored or co-authored using generative AI tooling?
No.

Closes apache#50307 from MaxGekk/assign-cond-2130.

Authored-by: Max Gekk <[email protected]>
Signed-off-by: Max Gekk <[email protected]>

Author: MaxGekk

common/utils/src/main/resources/error/error-conditions.json

@@ -2404,6 +2404,11 @@
         "message" : [
           "Cannot detect a seconds fraction pattern of variable length. Please make sure the pattern contains 'S', and does not contain illegal characters."
         ]
+      },
+      "WITH_SUGGESTION" : {
+        "message" : [
+          "You can form a valid datetime pattern with the guide from '<docroot>/sql-ref-datetime-pattern.html'."
+        ]
       }
     },
     "sqlState" : "22007"
@@ -7881,11 +7886,6 @@
       "Conflict found: Field <field> <actual> differs from <field> <expected> derived from <candidate>."
     ]
   },
-  "_LEGACY_ERROR_TEMP_2130" : {
-    "message" : [
-      "Fail to recognize '<pattern>' pattern in the DateTimeFormatter. You can form a valid datetime pattern with the guide from '<docroot>/sql-ref-datetime-pattern.html'."
-    ]
-  },
   "_LEGACY_ERROR_TEMP_2131" : {
     "message" : [
       "Exception when registering StreamingQueryListener."

sql/api/src/main/scala/org/apache/spark/sql/errors/ExecutionErrors.scala

@@ -73,7 +73,7 @@ private[sql] trait ExecutionErrors extends DataTypeErrorsBase {
 
   def failToRecognizePatternError(pattern: String, e: Throwable): SparkRuntimeException = {
     new SparkRuntimeException(
-      errorClass = "_LEGACY_ERROR_TEMP_2130",
+      errorClass = "INVALID_DATETIME_PATTERN.WITH_SUGGESTION",
       messageParameters =
         Map("pattern" -> toSQLValue(pattern), "docroot" -> SparkBuildInfo.spark_doc_root),
       cause = e)

sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/util/TimeFormatterSuite.scala

@@ -93,7 +93,7 @@ class TimeFormatterSuite extends SparkFunSuite with SQLHelper {
         exception = intercept[SparkRuntimeException] {
           TimeFormatter(invalidPattern)
         },
-        condition = "_LEGACY_ERROR_TEMP_2130",
+        condition = "INVALID_DATETIME_PATTERN.WITH_SUGGESTION",
         parameters = Map(
           "pattern" -> s"'$invalidPattern'",
           "docroot" -> SPARK_DOC_ROOT))

sql/core/src/test/resources/sql-tests/results/timestampNTZ/timestamp-ansi.sql.out

@@ -903,7 +903,8 @@ struct<>
 -- !query output
 org.apache.spark.SparkRuntimeException
 {
-  "errorClass" : "_LEGACY_ERROR_TEMP_2130",
+  "errorClass" : "INVALID_DATETIME_PATTERN.WITH_SUGGESTION",
+  "sqlState" : "22007",
   "messageParameters" : {
     "docroot" : "https://spark.apache.org/docs/latest",
     "pattern" : "'yyyy-MM-dd GGGGG'"
@@ -918,7 +919,8 @@ struct<>
 -- !query output
 org.apache.spark.SparkRuntimeException
 {
-  "errorClass" : "_LEGACY_ERROR_TEMP_2130",
+  "errorClass" : "INVALID_DATETIME_PATTERN.WITH_SUGGESTION",
+  "sqlState" : "22007",
   "messageParameters" : {
     "docroot" : "https://spark.apache.org/docs/latest",
     "pattern" : "'dd MM yyyy EEEEEE'"
@@ -933,7 +935,8 @@ struct<>
 -- !query output
 org.apache.spark.SparkRuntimeException
 {
-  "errorClass" : "_LEGACY_ERROR_TEMP_2130",
+  "errorClass" : "INVALID_DATETIME_PATTERN.WITH_SUGGESTION",
+  "sqlState" : "22007",
   "messageParameters" : {
     "docroot" : "https://spark.apache.org/docs/latest",
     "pattern" : "'dd MM yyyy EEEEE'"

sql/core/src/test/resources/sql-tests/results/timestampNTZ/timestamp.sql.out

@@ -880,7 +880,8 @@ struct<>
 -- !query output
 org.apache.spark.SparkRuntimeException
 {
-  "errorClass" : "_LEGACY_ERROR_TEMP_2130",
+  "errorClass" : "INVALID_DATETIME_PATTERN.WITH_SUGGESTION",
+  "sqlState" : "22007",
   "messageParameters" : {
     "docroot" : "https://spark.apache.org/docs/latest",
     "pattern" : "'yyyy-MM-dd GGGGG'"
@@ -895,7 +896,8 @@ struct<>
 -- !query output
 org.apache.spark.SparkRuntimeException
 {
-  "errorClass" : "_LEGACY_ERROR_TEMP_2130",
+  "errorClass" : "INVALID_DATETIME_PATTERN.WITH_SUGGESTION",
+  "sqlState" : "22007",
   "messageParameters" : {
     "docroot" : "https://spark.apache.org/docs/latest",
     "pattern" : "'dd MM yyyy EEEEEE'"
@@ -910,7 +912,8 @@ struct<>
 -- !query output
 org.apache.spark.SparkRuntimeException
 {
-  "errorClass" : "_LEGACY_ERROR_TEMP_2130",
+  "errorClass" : "INVALID_DATETIME_PATTERN.WITH_SUGGESTION",
+  "sqlState" : "22007",
   "messageParameters" : {
     "docroot" : "https://spark.apache.org/docs/latest",
     "pattern" : "'dd MM yyyy EEEEE'"