Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typo in librbl/rbl.c fails to build with -Werror on gcc14 #224

Open
tjwoodall opened this issue Aug 25, 2024 · 3 comments
Open

Typo in librbl/rbl.c fails to build with -Werror on gcc14 #224

tjwoodall opened this issue Aug 25, 2024 · 3 comments

Comments

@tjwoodall
Copy link

diff -ur opendkim.orig/librbl/rbl.c opendkim/librbl/rbl.c
--- opendkim.orig/librbl/rbl.c  2018-11-15 00:47:38.000000000 +0000
+++ opendkim/librbl/rbl.c       2024-08-25 12:05:44.169015382 +0000
@@ -329,7 +329,7 @@
 rbl_res_close(void *srv)
 {
 #ifdef HAVE_RES_NINIT
-       struct state *res;
+       struct __res_state *res;
 
        res = srv;

This appears to be a longstanding typo. c.f. dkim_res_close in libopendkim/dkim-dns.c

@futatuki
Copy link

Also rbl_res_nslist() has same type miss match in #ifdef HAVE_RES_SETSERVERS context.

@tjwoodall
Copy link
Author

Also in int dkim_res_nslist(void *srv, const char *nslist) { in libopendkim/dkim-dns.c

@futatuki
Copy link

Also in int dkim_res_nslist(void *srv, const char *nslist) { in libopendkim/dkim-dns.c

Ah, I remember they were proposed to be removed in PR #99

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants