Skip to content

Comments

chore: removes unused AI dev-dependency#1896

Merged
ctron merged 1 commit intoguacsec:mainfrom
helio-frota:unused-termimad-remaining-dep
Jul 24, 2025
Merged

chore: removes unused AI dev-dependency#1896
ctron merged 1 commit intoguacsec:mainfrom
helio-frota:unused-termimad-remaining-dep

Conversation

@helio-frota
Copy link
Contributor

@helio-frota helio-frota commented Jul 24, 2025

Summary by Sourcery

Remove the unused termimad development dependency from the workspace and its fundamental module

Chores:

  • Remove termimad from dev-dependencies in root Cargo.toml
  • Remove termimad from dev-dependencies in modules/fundamental/Cargo.toml
  • Update Cargo.lock to reflect the removal

@sourcery-ai
Copy link
Contributor

sourcery-ai bot commented Jul 24, 2025

Reviewer's Guide

This PR removes the unused AI-focused dev-dependency (termimad) from the workspace manifest files and updates the lock file to reflect the change.

File-Level Changes

Change Details Files
Removed unused dev-dependency termimad across the workspace
  • Delete termimad entry from dev-dependencies in root Cargo.toml
  • Delete termimad entry from dev-dependencies in modules/fundamental/Cargo.toml
  • Regenerate Cargo.lock to prune the removed dependency
Cargo.toml
modules/fundamental/Cargo.toml
Cargo.lock

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@helio-frota helio-frota requested a review from ctron July 24, 2025 12:39
Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @helio-frota - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@ctron ctron enabled auto-merge July 24, 2025 12:40
@codecov
Copy link

codecov bot commented Jul 24, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.14%. Comparing base (82c3738) to head (6db3f0d).
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1896      +/-   ##
==========================================
+ Coverage   68.06%   68.14%   +0.08%     
==========================================
  Files         365      365              
  Lines       23063    23123      +60     
  Branches    23063    23123      +60     
==========================================
+ Hits        15697    15758      +61     
+ Misses       6486     6485       -1     
  Partials      880      880              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ctron ctron added this pull request to the merge queue Jul 24, 2025
Merged via the queue into guacsec:main with commit 5a4c127 Jul 24, 2025
9 checks passed
@helio-frota helio-frota deleted the unused-termimad-remaining-dep branch August 20, 2025 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants