New Glassbreak Sensors

[alvinchen1]

Howdy! New official Ring Glassbreak sensors are shipping. https://ring.com/products/glass-break-sensor. Looks like the device is available, but untested, in the unofficial Ring API ring-client-api (https://github.com/dgreif/ring/blob/1691caa5cc0275460ff2961ad67d08f5007b30a8/homebridge/README.md#supported-devices-via-ring-alarm-and-ring-smart-lighting-hubs under Glassbreak sensors).

I've got a few of them and as expected when I start Ring-MQTT, when it is enumerating devices, the device is marked as unknown.

Unsupported device: sensor.glassbreak

Anything I might be able to help supply or provide to help add these devices to support? As mentioned in the ring-client-api there are three possible sensors that I think would make sense, similar to the supported Ring Motion Sensor

• Detect Glass Breaking (akin to Ring Motion Sensor Motion Detected? so binary_sensor, maybe device class "problem"?)
• Tamper (again, probably binary_sensor?)
• Battery (regular battery sensor?)

Anyway, happy to help and test if I can, you know maybe without breaking any of my windows, of course :)

Thanks for the awesome work!

[tsightler]

They are basically implemented as just another class of contact sensors. Technically I could, and probably should, combine all binary sensors into a single class, but for legacy reasons, motion sensors are their own class even though they are implemented in the API exactly like contact sensors, with the only difference being the device class.

Anyway, the glassbreak sensors should theoretically work in the dev branch, but I don't own any, so they are untested to this point. Feel free to give the dev branch a spin and let me know.

[alvinchen1]

Dev Channel worked and the devices now show up in discovery.

But only getting the Battery, Info, and Tamper sensors (which all look great). No binary_sensor of class Problem.

So this maybe an issue at the ring-client-api level?

[tsightler]

I think it's just a stupid bug (missing a break in the case statement so it was falling through to the generic function). Restart should pull in the fix.

[alvinchen1]

Worked! Kick ass!

I am going to assume that means it is working. Not sure how I'm gonna test a glass shatter, but at least this seems to bubble up the devices and sensors. Maybe I'll start drinking early today and smash a beer bottle or two to test... :)

Now, just gotta wait till we get issue #319 working for my new Floodlight Pro camera arriving tomorrow... Might hold off installing that till that gets resolved. Thanks again!

[tsightler]

Honestly, I'm not sure what is causing that issue. The returned API data from the Floodlight Pro looks nearly identical in most respects to all other Ring cameras and there's no model specific differences in ring-client-api. The only thing that should be the case is that the device model would display as unknown because it's not in the list (below is the line from ring-client-api):

this.model = RingCameraModel[this.initialData.kind] || 'Unknown Model'

There's absolutely zero model specific code in the camera handler, it literally just looks at the data returned by the API and determines if given features are there or not, and ring-mqtt depends on those indicators. There's been no other users reports that the Floodlight Pro doesn't work, in either project, and I can't image that there aren't some out there already, and that user as, so far, not provided the request debug logs from ring-mqtt, so I don't really have any way to look into it deeper as I don't plan on buying one any time soon as I'm not convinced I'm going to keep investing into an ecosystem that seems to be closing more in every product release, even if I do understand it from their business perspective.

So, I guess my point is, if you do install it, please report your success/failure and provide debug logs as that will likely move it along much more quickly as I'm not convinced this issue is just the single missing entry in ring-client-api or I think the camera wouldn't show up at all.

[SeraphimSerapis]

Ha, I was just about to open a topic and then saw this one. I'd also love to see support for this device! Please let me know if there's anything I could do to help.

[alvinchen1]

Yup @tsightler agree. That totally makes sense, safety device type over problem device type. When do we think dev might merge into master? Based upon when you think that will deploy, I may or may not remain in dev.

[tsightler]

It will be a while as dev is currently primarily focused on upcoming major changes in config/state management, at least a few weeks I'd guess, maybe more since I have limited time available in the coming weeks. Admittedly most of the basis for that work is already in there, so it might be quicker if I magically find an extra few hours to finish the cleanup of the main initialization routine, do all the required testing for the various install methods, and update the docs.

If it goes on too long I'll probably try to pull the device updates into the 4.9.x branch, especially if we find out there are changes needed to support the Floodlight Pro. That being said, there's not much risk to running the dev branch, other than it could be broken at any given minute, but usually if this happens you can restart a few minutes later and it will be fixed because I try to keep it in working state since I run it 100% of the time on my dev instance and quite regularly on my production instance, especially if I want to do some long term testing.

[alvinchen1]

Cool. Even though I don't need those break glass sensors for really anything right now, I'll stay on dev for a bit then. Especially, if it would be helpful to get logs for any other work you might be doing. I'm fine testing and living on the bleeding edge a while. Also, any way you'd like me to mark this thread as 'resolved in dev', so we don't have other folks saying "Me too..." etc? Just minimize the noise so you can focus on what you need to focus on?

[tsightler]

I've added a "queued for release" tag to this thread.

Also, if you do get that Pro installed, please let me know how it goes and provide some logs of needed, I'd like to get that resolved.

[SeraphimSerapis]

I gave this a try and things seem to work well on dev. Thanks for the great work, @tsightler