Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Naming conflit in expose observation setup #197

Open
valeriof7 opened this issue Nov 25, 2024 · 1 comment
Open

Naming conflit in expose observation setup #197

valeriof7 opened this issue Nov 25, 2024 · 1 comment

Comments

@valeriof7
Copy link
Contributor

There is a naming conflict in the tudatpy/tudatpy/kernel/expose_numerical_simulation/expose_estimation_setup/expose_observation_setup.cpp file between the observable type objects and the names of the Python functions used to create the associated observation model and define its settings. For example, the object for the dsn n-way range is usually called as follows

tudatpy.numerical_simulation.estimation_setup.observation.dsn_n_way_range

While the associated observation settings are (currently) created using

tudatpy.numerical_simulation.estimation_setup.observation.dsn_n_way_Range(
                    current_link_definition, light_time_correction_list
                )

I think a refactoring of the naming for the observation settings (e.g. using something like create_n_way_range or n_way_range_settings) should be done.

@DominicDirkx
Copy link
Member

In line with (most) of the other entries of the ObservableType enum, I propose we name the entry there. Proposed correction pushed to feature branch:
8d3d947

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: No status
Development

No branches or pull requests

2 participants