You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
There is a naming conflict in the tudatpy/tudatpy/kernel/expose_numerical_simulation/expose_estimation_setup/expose_observation_setup.cpp file between the observable type objects and the names of the Python functions used to create the associated observation model and define its settings. For example, the object for the dsn n-way range is usually called as follows
I think a refactoring of the naming for the observation settings (e.g. using something like create_n_way_range or n_way_range_settings) should be done.
The text was updated successfully, but these errors were encountered:
In line with (most) of the other entries of the ObservableType enum, I propose we name the entry there. Proposed correction pushed to feature branch: 8d3d947
There is a naming conflict in the
tudatpy/tudatpy/kernel/expose_numerical_simulation/expose_estimation_setup/expose_observation_setup.cpp
file between the observable type objects and the names of the Python functions used to create the associated observation model and define its settings. For example, the object for the dsn n-way range is usually called as followsWhile the associated observation settings are (currently) created using
I think a refactoring of the naming for the observation settings (e.g. using something like create_n_way_range or n_way_range_settings) should be done.
The text was updated successfully, but these errors were encountered: