Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nonexistent functions in select clause result columns are ignored #573

Open
jussisaurio opened this issue Dec 29, 2024 · 3 comments
Open

nonexistent functions in select clause result columns are ignored #573

jussisaurio opened this issue Dec 29, 2024 · 3 comments
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@jussisaurio
Copy link
Collaborator 

limbo> select this_definitely_exists('lol');
NULL

(no error)

Bug is due to this line: https://github.com/tursodatabase/limbo/blob/main/core/translate/planner.rs#L365
@jussisaurio jussisaurio added bug Something isn't working good first issue Good for newcomers labels Dec 29, 2024
@jussisaurio jussisaurio mentioned this issue Dec 29, 2024
Merged
@jikrow jikrow mentioned this issue Dec 30, 2024
Closed
@jikrow
Copy link

jikrow commented Dec 30, 2024

@jussisaurio I've taken a shot at this here: #576

@penberg penberg added the Stale label Jan 30, 2025
@jussisaurio
Copy link
Collaborator Author

This returns a parse error now, closing

@penberg penberg reopened this Feb 24, 2025
@penberg penberg removed the Stale label Feb 25, 2025
@levydsa
Copy link
Contributor

levydsa commented Mar 10, 2025

@penberg, why was this reopen? The issue seems to be fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Raise error on non-resolution of function jikrow/limbo
4 participants
@penberg @jussisaurio @levydsa @jikrow