core/io: Improve error handling

Author: penberg

core/io/clock.rs

@@ -72,15 +72,17 @@ impl std::ops::Add<Duration> for Instant {
     type Output = Instant;
 
     fn add(self, rhs: Duration) -> Self::Output {
-        self.checked_add_duration(&rhs).unwrap()
+        self.checked_add_duration(&rhs)
+            .expect("duration addition overflow")
     }
 }
 
 impl std::ops::Sub<Duration> for Instant {
     type Output = Instant;
 
     fn sub(self, rhs: Duration) -> Self::Output {
-        self.checked_sub_duration(&rhs).unwrap()
+        self.checked_sub_duration(&rhs)
+            .expect("duration subtraction underflow")
     }
 }
 

core/io/completions.rs

@@ -272,7 +272,9 @@ impl Completion {
     }
 
     pub(super) fn get_inner(&self) -> &Arc<CompletionInner> {
-        self.inner.as_ref().unwrap()
+        self.inner
+            .as_ref()
+            .expect("completion inner should be initialized")
     }
 
     pub fn needs_link(&self) -> bool {

core/io/memory.rs

@@ -59,7 +59,12 @@ impl IO for MemoryIO {
                 }),
             );
         }
-        Ok(files.get(path).unwrap().clone())
+        Ok(files
+            .get(path)
+            .ok_or(crate::LimboError::InternalError(
+                "file should exist after insert".to_string(),
+            ))?
+            .clone())
     }
     fn remove_file(&self, path: &str) -> Result<()> {
         let mut files = self.files.lock();