mark attach as experimental

Author: jussisaurio

cli/app.rs

@@ -86,6 +86,8 @@ pub struct Opts {
     pub experimental_autovacuum: bool,
     #[clap(long, help = "Enable experimental triggers feature")]
     pub experimental_triggers: bool,
+    #[clap(long, help = "Enable experimental attach feature")]
+    pub experimental_attach: bool,
 }
 
 const PROMPT: &str = "turso> ";
@@ -196,7 +198,8 @@ impl Limbo {
                     .with_strict(opts.experimental_strict)
                     .with_encryption(opts.experimental_encryption)
                     .with_index_method(opts.experimental_index_method)
-                    .with_triggers(opts.experimental_triggers),
+                    .with_triggers(opts.experimental_triggers)
+                    .with_attach(opts.experimental_attach),
             )?
         } else {
             let flags = if opts.readonly {
@@ -215,6 +218,7 @@ impl Limbo {
                     .with_index_method(opts.experimental_index_method)
                     .with_autovacuum(opts.experimental_autovacuum)
                     .with_triggers(opts.experimental_triggers)
+                    .with_attach(opts.experimental_attach)
                     .turso_cli(),
                 None,
             )?;

core/incremental/cursor.rs

@@ -318,6 +318,7 @@ mod tests {
                 enable_index_method: false,
                 enable_autovacuum: false,
                 enable_triggers: false,
+                enable_attach: false,
             },
             None,
         )?;

core/lib.rs

@@ -121,6 +121,7 @@ pub struct DatabaseOpts {
     pub enable_index_method: bool,
     pub enable_autovacuum: bool,
     pub enable_triggers: bool,
+    pub enable_attach: bool,
     enable_load_extension: bool,
 }
 
@@ -164,6 +165,11 @@ impl DatabaseOpts {
         self.enable_triggers = enable;
         self
     }
+
+    pub fn with_attach(mut self, enable: bool) -> Self {
+        self.enable_attach = enable;
+        self
+    }
 }
 
 #[derive(Clone, Debug, Default)]
@@ -1042,6 +1048,10 @@ impl Database {
         self.opts.enable_triggers
     }
 
+    pub fn experimental_attach_enabled(&self) -> bool {
+        self.opts.enable_attach
+    }
+
     /// check if database is currently in MVCC mode
     pub fn mvcc_enabled(&self) -> bool {
         self.mv_store.load().is_some()
@@ -2242,6 +2252,10 @@ impl Connection {
         self.db.experimental_triggers_enabled()
     }
 
+    pub fn experimental_attach_enabled(&self) -> bool {
+        self.db.experimental_attach_enabled()
+    }
+
     pub fn mvcc_enabled(&self) -> bool {
         self.db.mvcc_enabled()
     }

core/translate/attach.rs

@@ -4,7 +4,9 @@ use crate::translate::expr::{sanitize_string, translate_expr};
 use crate::translate::{ProgramBuilder, ProgramBuilderOpts};
 use crate::util::normalize_ident;
 use crate::vdbe::insn::Insn;
+use crate::Connection;
 use crate::Result;
+use std::sync::Arc;
 use turso_parser::ast::{Expr, Literal};
 
 /// Translate ATTACH statement
@@ -15,7 +17,13 @@ pub fn translate_attach(
     db_name: &Expr,
     key: &Option<Box<Expr>>,
     mut program: ProgramBuilder,
+    connection: Arc<Connection>,
 ) -> Result<ProgramBuilder> {
+    if !connection.experimental_attach_enabled() {
+        return Err(crate::LimboError::ParseError(
+            "ATTACH is an experimental feature. Enable with --experimental-attach flag".to_string(),
+        ));
+    }
     // SQLite treats ATTACH as a function call to sqlite_attach(filename, dbname, key)
     // We'll allocate registers for the arguments and call the function
 
@@ -119,7 +127,13 @@ pub fn translate_detach(
     expr: &Expr,
     resolver: &Resolver,
     mut program: ProgramBuilder,
+    connection: Arc<Connection>,
 ) -> Result<ProgramBuilder> {
+    if !connection.experimental_attach_enabled() {
+        return Err(crate::LimboError::ParseError(
+            "DETACH is an experimental feature. Enable with --experimental-attach flag".to_string(),
+        ));
+    }
     // SQLite treats DETACH as a function call to sqlite_detach(dbname)
 
     program.extend(&ProgramBuilderOpts {

core/translate/mod.rs

@@ -152,7 +152,7 @@ pub fn translate_inner(
         }
         ast::Stmt::Analyze { name } => translate_analyze(name, resolver, program)?,
         ast::Stmt::Attach { expr, db_name, key } => {
-            attach::translate_attach(&expr, resolver, &db_name, &key, program)?
+            attach::translate_attach(&expr, resolver, &db_name, &key, program, connection.clone())?
         }
         ast::Stmt::Begin { typ, name } => translate_tx_begin(typ, name, resolver.schema, program)?,
         ast::Stmt::Commit { name } => translate_tx_commit(name, program)?,
@@ -261,7 +261,9 @@ pub fn translate_inner(
                 connection,
             )?
         }
-        ast::Stmt::Detach { name } => attach::translate_detach(&name, resolver, program)?,
+        ast::Stmt::Detach { name } => {
+            attach::translate_detach(&name, resolver, program, connection.clone())?
+        }
         ast::Stmt::DropIndex {
             if_exists,
             idx_name,

macros/src/test.rs

@@ -61,6 +61,7 @@ impl Args {
                 .with_index_method(true)
                 .with_encryption(true)
                 .with_triggers(true)
+                .with_attach(true)
         };
 
         builder = quote! {

scripts/limbo-sqlite3

@@ -7,7 +7,7 @@ PROJECT_ROOT="$(dirname "$SCRIPT_DIR")"
 TURSODB="$PROJECT_ROOT/target/debug/tursodb"
 
 # Add experimental features for testing
-EXPERIMENTAL_FLAGS="--experimental-views --experimental-strict --experimental-triggers"
+EXPERIMENTAL_FLAGS="--experimental-views --experimental-strict --experimental-triggers --experimental-attach"
 
 # if RUST_LOG is non-empty, enable tracing output
 if [ -n "$RUST_LOG" ]; then

scripts/turso-mvcc-sqlite3

@@ -8,7 +8,7 @@ TURSODB="$PROJECT_ROOT/target/debug/tursodb"
 
 # Add experimental features for testing
 # Note: MVCC is enabled via PRAGMA journal_mode = 'experimental_mvcc'
-EXPERIMENTAL_FLAGS="--experimental-views --experimental-strict --experimental-triggers"
+EXPERIMENTAL_FLAGS="--experimental-views --experimental-strict --experimental-triggers --experimental-attach"
 
 # if RUST_LOG is non-empty, enable tracing output
 if [ -n "$RUST_LOG" ]; then

sdk-kit/src/rsapi.rs

@@ -497,6 +497,7 @@ impl TursoDatabase {
                     "strict" => opts.with_strict(true),
                     "autovacuum" => opts.with_autovacuum(true),
                     "triggers" => opts.with_triggers(true),
+                    "attach" => opts.with_attach(true),
                     _ => opts,
                 };
             }