fix panic in aggr queries for n_key_col, return 0 if no grpby

Author: Pavan-Nambi

core/translate/insert.rs

@@ -2842,11 +2842,9 @@ fn translate_without_rowid_insert(
         description: format_unique_violation_desc(&table.name, pk_index),
     });
 
-
     program.preassign_label_to_next_insn(ok_to_insert_label);
     tracing::debug!("Uniqueness check passed. Continuing with insertion.");
 
-
     let physically_ordered_cols: Vec<&Column> = {
         let mut ordered = Vec::with_capacity(table.columns.len());
         let mut pk_cols_added = std::collections::HashSet::new();
@@ -2903,7 +2901,6 @@ fn translate_without_rowid_insert(
         .map(|col| col.affinity().aff_mask())
         .collect::<String>();
 
-
     program.emit_insn(Insn::MakeRecord {
         start_reg: reordered_start_reg,
         count: insertion.col_mappings.len(),
@@ -2912,8 +2909,6 @@ fn translate_without_rowid_insert(
         affinity_str: Some(affinity_str),
     });
 
-
-
     program.emit_insn(Insn::IdxInsert {
         cursor_id: pk_cursor_id,
         record_reg: full_record_reg,

core/translate/main_loop.rs

@@ -189,7 +189,11 @@ pub fn init_loop(
             where_clause: None,
             index_method: None,
             is_primary_key: false,
-            n_key_col: group_by.as_ref().unwrap().exprs.len(),
+            n_key_col: if let Some(gb) = group_by.as_ref() {
+                gb.exprs.len()
+            } else {
+                0
+            },
         });
         let cursor_id = program.alloc_cursor_id(CursorType::BTreeIndex(index.clone()));
         if group_by.is_none() {

core/translate/schema.rs

@@ -452,7 +452,6 @@ fn collect_autoindexes(
         };
 
         let needs_index = if us.is_primary_key {
-
             !(is_without_rowid || (col.primary_key() && col.is_rowid_alias()))
         } else {
             // UNIQUE single needs an index