Pass experimental feature flags from JS/python bindings

Author: jussisaurio

bindings/javascript/packages/common/types.ts

@@ -1,8 +1,12 @@
+export type ExperimentalFeature = 'views' | 'strict' | 'encryption' | 'index_method' | 'autovacuum' | 'triggers' | 'attach';
+
 export interface DatabaseOpts {
     readonly?: boolean,
     fileMustExist?: boolean,
     timeout?: number
     tracing?: 'info' | 'debug' | 'trace'
+    /** Experimental features to enable */
+    experimental?: ExperimentalFeature[]
 }
 
 export interface NativeDatabase {

bindings/javascript/packages/native/compat.test.ts

@@ -84,10 +84,10 @@ test('attach', () => {
     const path1 = `test-${(Math.random() * 10000) | 0}.db`;
     const path2 = `test-${(Math.random() * 10000) | 0}.db`;
     try {
-        const db1 = new Database(path1);
+        const db1 = new Database(path1, { experimental: ["attach"] });
         db1.exec("CREATE TABLE t(x)");
         db1.exec("INSERT INTO t VALUES (1), (2), (3)");
-        const db2 = new Database(path2);
+        const db2 = new Database(path2, { experimental: ["attach"] });
         db2.exec("CREATE TABLE q(x)");
         db2.exec("INSERT INTO q VALUES (4), (5), (6)");
 

bindings/javascript/packages/native/promise.test.ts

@@ -207,10 +207,10 @@ test('attach', async () => {
     const path1 = `test-${(Math.random() * 10000) | 0}.db`;
     const path2 = `test-${(Math.random() * 10000) | 0}.db`;
     try {
-        const db1 = await connect(path1);
+        const db1 = await connect(path1, { experimental: ["attach"] });
         await db1.exec("CREATE TABLE t(x)");
         await db1.exec("INSERT INTO t VALUES (1), (2), (3)");
-        const db2 = await connect(path2);
+        const db2 = await connect(path2, { experimental: ["attach"] });
         await db2.exec("CREATE TABLE q(x)");
         await db2.exec("INSERT INTO q VALUES (4), (5), (6)");
 

bindings/javascript/src/lib.rs

@@ -123,6 +123,8 @@ pub struct DatabaseOpts {
     pub timeout: Option<u32>,
     pub file_must_exist: Option<bool>,
     pub tracing: Option<String>,
+    /// Experimental features to enable
+    pub experimental: Option<Vec<String>>,
 }
 
 fn step_sync(stmt: &Arc<RefCell<turso_core::Statement>>) -> napi::Result<u32> {
@@ -162,6 +164,7 @@ fn connect_sync(db: &DatabaseInner) -> napi::Result<()> {
 
     let mut flags = turso_core::OpenFlags::Create;
     let mut busy_timeout = None;
+    let mut core_opts = turso_core::DatabaseOpts::new();
     if let Some(opts) = &db.opts {
         if opts.readonly == Some(true) {
             flags.set(turso_core::OpenFlags::ReadOnly, true);
@@ -173,16 +176,25 @@ fn connect_sync(db: &DatabaseInner) -> napi::Result<()> {
         if let Some(timeout) = opts.timeout {
             busy_timeout = Some(std::time::Duration::from_millis(timeout as u64));
         }
+        if let Some(experimental) = &opts.experimental {
+            for feature in experimental {
+                core_opts = match feature.as_str() {
+                    "views" => core_opts.with_views(true),
+                    "strict" => core_opts.with_strict(true),
+                    "encryption" => core_opts.with_encryption(true),
+                    "index_method" => core_opts.with_index_method(true),
+                    "autovacuum" => core_opts.with_autovacuum(true),
+                    "triggers" => core_opts.with_triggers(true),
+                    "attach" => core_opts.with_attach(true),
+                    _ => core_opts,
+                };
+            }
+        }
     }
     let io = &db.io;
-    let db_core = turso_core::Database::open_file_with_flags(
-        io.clone(),
-        &db.path,
-        flags,
-        turso_core::DatabaseOpts::new(),
-        None,
-    )
-    .map_err(|e| to_generic_error(&format!("failed to open database {}", db.path), e))?;
+    let db_core =
+        turso_core::Database::open_file_with_flags(io.clone(), &db.path, flags, core_opts, None)
+            .map_err(|e| to_generic_error(&format!("failed to open database {}", db.path), e))?;
 
     let conn = db_core
         .connect()

testing/cli_tests/cli_test_cases.py

@@ -372,7 +372,7 @@ def test_parse_error():
 
 
 def test_tables_with_attached_db():
-    shell = TestTursoShell()
+    shell = TestTursoShell(flags="-q --experimental-attach")
     shell.execute_dot(".open :memory:")
     shell.execute_dot("CREATE TABLE orders(a);")
     shell.execute_dot("ATTACH DATABASE 'testing/testing.db' AS attached;")