Merge 'drop triggers if table drops' from Pavan Nambi

seed: 3038621321660758567

Reviewed-by: Jussi Saurio <[email protected]>

Closes #4005

Author: jussisaurio

core/schema.rs

@@ -397,6 +397,10 @@ impl Schema {
         }
         Ok(())
     }
+    pub fn remove_triggers_for_table(&mut self, table_name: &str) {
+        let table_name = normalize_ident(table_name);
+        self.triggers.remove(&table_name);
+    }
 
     pub fn get_trigger_for_table(&self, table_name: &str, name: &str) -> Option<Arc<Trigger>> {
         let table_name = normalize_ident(table_name);

core/vdbe/execute.rs

@@ -7746,6 +7746,7 @@ pub fn op_drop_table(
     {
         conn.with_schema_mut(|schema| {
             schema.remove_indices_for_table(table_name);
+            schema.remove_triggers_for_table(table_name);
             schema.remove_table(table_name);
         });
     }

testing/trigger.test

@@ -758,4 +758,19 @@ do_execsql_test_on_specific_db {:memory:} trigger-multiple-before-insert-lifo {
 2|3|4|5|t67_second
 3|4|6|8|t67_second
 4|2|3|4|t67_first
-5|1|1|1|jussi}
+5|1|1|1|jussi}
+
+# dropping table should drop triggers
+do_execsql_test_on_specific_db {:memory:} trigger-drop-make-same-table{
+  create table a(id int primary key, x int);
+  create table t(id int primary key, b int, d int, c int);
+  create table t1(id int, y int); create trigger trg after insert on t begin update a set x = x - new.d + new.c where id = new.b; insert into t1(id, y) values (new.id, new.c - new.d); end; insert into a values (1, 5000);
+  insert into a values (2, 3000); 
+  drop table t; 
+  create table t(id int primary key, b int, c int, d int); 
+  insert into t values (1, 1, 1000, 50); 
+  insert into t values (2, 2, 500, 100); 
+  select * from a;
+  select * from t1;
+} {1|5000
+2|3000}