Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature]: allow peer dep of typescript v5 #497

Closed
osdiab opened this issue Nov 7, 2023 · 3 comments · May be fixed by #498
Closed

[Feature]: allow peer dep of typescript v5 #497

osdiab opened this issue Nov 7, 2023 · 3 comments · May be fixed by #498
Labels
🛑 Abandoned The issue or Pull Request will not be worked on ✨ Feature Request Something should be added

Comments

@osdiab
Copy link

osdiab commented Nov 7, 2023

Describe the problem

@twind/core right now has a peer dependency requirement of typescript@^4, but typescript v5 has been out for a while, so adding this package also causes there to be peer dependency errors because i use the newer version of typescript

Describe the proposed solution

more permissive peer dep version for typescript, e.g. >4 or ^4 || ^5

Alternatives considered

No response

Importance

nice to have

Additional Information

No response
@osdiab osdiab added the ✨ Feature Request Something should be added label Nov 7, 2023
@osdiab osdiab mentioned this issue Nov 7, 2023
Open
5 tasks
@AndreLeifert
Copy link

not just @twind/core - presets, too

@kasvith
Copy link

kasvith commented Apr 3, 2024

Hi im facing the same issue with peerDeps

@AlexanderArvidsson AlexanderArvidsson mentioned this issue Jul 19, 2024
Open
@stale stale bot added the 🛑 Abandoned The issue or Pull Request will not be worked on label Dec 29, 2024
@stale Stale
Copy link

stale bot commented Jan 29, 2025

Hey folks. This issue hasn't received any traction for 90 days, so we're going to close this for housekeeping. If this is still an ongoing issue, please do consider contributing a Pull Request to resolve it. Further discussion is always welcome even with the issue closed. If anything actionable is posted in the comments, we'll consider reopening it. ⓘ

@stale stale bot closed this as completed Jan 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
🛑 Abandoned The issue or Pull Request will not be worked on ✨ Feature Request Something should be added
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

allow typescript v5 osdiab/twind
3 participants
@osdiab @AndreLeifert @kasvith