Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Various OCaml fixes #907

Merged
merged 4 commits into from
Mar 17, 2025
Merged

Various OCaml fixes #907

merged 4 commits into from
Mar 17, 2025

Conversation

nbacquey
Copy link
Member

@nbacquey nbacquey commented Mar 11, 2025

Closes #661
Closes #816
Closes #820

Checklist

Checklist before merging, wherever relevant:

@nbacquey nbacquey changed the base branch from main to nb/fix_ocaml_1 March 12, 2025 17:47
Base automatically changed from nb/fix_ocaml_1 to main March 14, 2025 09:12
@Xophmeister
Copy link
Member

@nbacquey I merged #908 and rebased this branch off the new main to resolve the conflicts. Please double-check before you pull, in case I accidentally broke something 👌

@nbacquey nbacquey force-pushed the nb/fix_ocaml branch 2 times, most recently from 8d51a8f to e90f2fd Compare March 17, 2025 16:42
This commit fixes various warnings happening during the processing of
the `.ml` and `.mli` sample input files
@nbacquey nbacquey marked this pull request as ready for review March 17, 2025 16:47
Copy link
Member

@Xophmeister Xophmeister left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great; thanks 🙏

@nbacquey nbacquey merged commit 6cbdce7 into main Mar 17, 2025
10 checks passed
@nbacquey nbacquey deleted the nb/fix_ocaml branch March 17, 2025 23:52
@Niols
Copy link
Member

Niols commented Mar 18, 2025

♥️ ♥️ ♥️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants