Commit 5f20276
committed
fix(twenty-front): fix tsconfig to properly typecheck all files with tsgo
The previous tsconfig setup used project references with `files: []`, which
caused `tsgo -p tsconfig.json` to check nothing (tsgo requires the configs
to include files directly, not through project references).
## Changes by package
### twenty-front
- Simplified from 4 configs to 2: tsconfig.json (all files) + tsconfig.build.json (prod)
- Removed: tsconfig.dev.json, tsconfig.spec.json, tsconfig.storybook.json
- Updated jest.config.mjs, eslint.config.mjs, vite.config.ts references
- Made applicationId optional in FieldMetadataItem and ObjectMetadataItem
- Added missing navigationMenuItem translation
- Added objectLabelSingular to Search GraphQL query
### twenty-ui
- Simplified from 5 configs to 2: tsconfig.json (all files) + tsconfig.lib.json (build)
- Removed: tsconfig.dev.json, tsconfig.spec.json, tsconfig.storybook.json
- Removed baseUrl (not supported by tsgo)
- Updated vite.config.ts and .storybook/main.ts references
### twenty-shared
- Simplified from 3 configs to 2: tsconfig.json (all files) + tsconfig.lib.json (build)
- Removed: tsconfig.spec.json
- Removed baseUrl (not supported by tsgo)
### twenty-sdk
- Simplified from 3 configs to 2: tsconfig.json (all files) + tsconfig.lib.json (build)
- Removed: tsconfig.spec.json
### twenty-emails
- Simplified to single tsconfig.json (all files)
### twenty-eslint-rules
- Simplified from 3 configs to 1: tsconfig.json (all files)
- Removed: tsconfig.lint.json, tsconfig.spec.json
- Updated jest.config.mjs reference
### create-twenty-app
- Simplified from 3 configs to 2: tsconfig.json (all files) + tsconfig.lib.json (build)
- Removed: tsconfig.spec.json
## Note on pre-existing type errors
Proper type checking now reveals ~77 pre-existing errors in twenty-front and
~1100 in twenty-server that were previously hidden. These are primarily:
- Icon prop type mismatches (twenty-ui icons have required props that are
optional in IconComponentProps)
- Type inference issues with Object.keys() returning string | number | symbol
These should be fixed in follow-up PRs.File tree
349 files changed
+3045
-1977
lines changed- .vscode
- packages
- create-twenty-app
- src
- constants/base-application
- utils
- __tests__
- twenty-emails
- twenty-eslint-rules
- twenty-front/src
- generated-metadata
- generated
- locales
- generated
- modules
- activities
- calendar/components
- files/components
- hooks
- tasks/hooks
- favorites/hooks
- localization/hooks
- __tests__
- object-record
- hooks
- __tests__
- record-board/components
- record-calendar/record-calendar-card/components
- record-drag/hooks
- record-field-list/record-detail-section/relation/components
- record-field/ui
- components
- hooks
- __tests__
- meta-types/input/hooks
- __tests__
- record-index/components
- record-inline-cell
- components
- property-box/components
- record-show/hooks
- page-layout
- components
- constants
- hooks
- states
- utils
- __tests__
- widgets
- components
- fields
- components
- hooks
- field/components
- graph
- graphWidgetBarChart
- components
- utils
- graphWidgetLineChart/components
- settings
- accounts/components
- data-model/object-details/components
- profile/components
- roles/role-permissions/object-level-permissions/field-permissions/components
- workspace-member/components
- ui
- input/editor/hooks
- theme/hooks
- workflow
- utils
- __tests__
- workflow-trigger/hooks
- __tests__
- workflow-variables/utils
- pages
- onboarding
- settings
- members
- profile/appearance/components
- twenty-sdk
- src
- application
- front-components
- functions
- cli
- __tests__
- apps
- rich-app/__integration__/app-dev
- tests
- root-app/__integration__/app-dev
- tests
- integration/utils
- commands
- app
- function
- utilities
- build
- common
- front-components
- functions
- manifest
- __tests__
- entities
- entity/utils
- __tests__
- twenty-server/src
- engine
- core-modules
- applicationVariable/types
- application
- feature-flag
- constants
- enums
- i18n/locales
- generated
- imap-smtp-caldav-connection/services
- user/types
- metadata-modules
- cron-trigger/types
- database-event-trigger/types
- field-metadata
- types/__tests__
- flat-agent/types
- flat-entity
- constant
- types
- __tests__
- utils
- flat-field-metadata/types
- __tests__
- flat-front-component/types
- flat-index-metadata/types
- flat-object-metadata/types
- flat-page-layout-tab/types
- flat-page-layout-widget/types
- flat-page-layout/types
- flat-role-target/types
- flat-role/types
- flat-skill/types
- flat-view-field/types
- flat-view-filter-group/types
- flat-view-filter/types
- flat-view-group/types
- flat-view/types
- route-trigger/types
- row-level-permission-predicate/types
- serverless-function-layer/types
- serverless-function/types
- twenty-orm/entity-manager
- workspace-manager
- dev-seeder/core/utils
- workspace-migration
- universal-flat-entity/types
- __tests__
- utils
- __tests__
- modules
- calendar/calendar-event-import-manager/drivers/caldav/lib
- workflow/workflow-builder/workflow-schema/utils
- twenty-ui
- .storybook
Some content is hidden
Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.
349 files changed
+3045
-1977
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
54 | 54 | | |
55 | 55 | | |
56 | 56 | | |
57 | | - | |
| 57 | + | |
58 | 58 | | |
Lines changed: 4 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
22 | 22 | | |
23 | 23 | | |
24 | 24 | | |
| 25 | + | |
| 26 | + | |
| 27 | + | |
| 28 | + | |
25 | 29 | | |
26 | 30 | | |
27 | 31 | | |
Lines changed: 6 additions & 9 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
41 | 41 | | |
42 | 42 | | |
43 | 43 | | |
44 | | - | |
| 44 | + | |
45 | 45 | | |
46 | 46 | | |
47 | 47 | | |
| |||
114 | 114 | | |
115 | 115 | | |
116 | 116 | | |
117 | | - | |
118 | 117 | | |
119 | 118 | | |
120 | 119 | | |
| |||
127 | 126 | | |
128 | 127 | | |
129 | 128 | | |
130 | | - | |
| 129 | + | |
131 | 130 | | |
132 | 131 | | |
133 | 132 | | |
| |||
156 | 155 | | |
157 | 156 | | |
158 | 157 | | |
159 | | - | |
160 | 158 | | |
161 | 159 | | |
162 | 160 | | |
| |||
216 | 214 | | |
217 | 215 | | |
218 | 216 | | |
219 | | - | |
220 | 217 | | |
221 | 218 | | |
222 | 219 | | |
| |||
247 | 244 | | |
248 | 245 | | |
249 | 246 | | |
250 | | - | |
| 247 | + | |
251 | 248 | | |
252 | 249 | | |
253 | 250 | | |
254 | | - | |
| 251 | + | |
255 | 252 | | |
256 | 253 | | |
257 | 254 | | |
| |||
289 | 286 | | |
290 | 287 | | |
291 | 288 | | |
292 | | - | |
| 289 | + | |
293 | 290 | | |
294 | 291 | | |
295 | 292 | | |
296 | | - | |
| 293 | + | |
297 | 294 | | |
298 | 295 | | |
299 | 296 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
2 | 2 | | |
3 | 3 | | |
4 | 4 | | |
5 | | - | |
| 5 | + | |
6 | 6 | | |
7 | 7 | | |
8 | 8 | | |
| |||
36 | 36 | | |
37 | 37 | | |
38 | 38 | | |
| 39 | + | |
| 40 | + | |
| 41 | + | |
| 42 | + | |
39 | 43 | | |
40 | 44 | | |
41 | 45 | | |
| |||
67 | 71 | | |
68 | 72 | | |
69 | 73 | | |
| 74 | + | |
70 | 75 | | |
71 | 76 | | |
72 | 77 | | |
| |||
139 | 144 | | |
140 | 145 | | |
141 | 146 | | |
142 | | - | |
| 147 | + | |
143 | 148 | | |
144 | 149 | | |
145 | 150 | | |
| |||
151 | 156 | | |
152 | 157 | | |
153 | 158 | | |
| 159 | + | |
| 160 | + | |
| 161 | + | |
| 162 | + | |
| 163 | + | |
| 164 | + | |
| 165 | + | |
| 166 | + | |
| 167 | + | |
| 168 | + | |
| 169 | + | |
| 170 | + | |
| 171 | + | |
| 172 | + | |
| 173 | + | |
| 174 | + | |
| 175 | + | |
| 176 | + | |
| 177 | + | |
| 178 | + | |
| 179 | + | |
| 180 | + | |
| 181 | + | |
| 182 | + | |
| 183 | + | |
| 184 | + | |
| 185 | + | |
| 186 | + | |
| 187 | + | |
| 188 | + | |
| 189 | + | |
| 190 | + | |
| 191 | + | |
| 192 | + | |
| 193 | + | |
154 | 194 | | |
155 | 195 | | |
156 | 196 | | |
| |||
161 | 201 | | |
162 | 202 | | |
163 | 203 | | |
164 | | - | |
| 204 | + | |
165 | 205 | | |
166 | 206 | | |
167 | 207 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | 1 | | |
| 2 | + | |
2 | 3 | | |
3 | 4 | | |
4 | 5 | | |
| |||
8 | 9 | | |
9 | 10 | | |
10 | 11 | | |
| 12 | + | |
11 | 13 | | |
12 | 14 | | |
13 | 15 | | |
14 | 16 | | |
15 | | - | |
16 | | - | |
17 | | - | |
18 | | - | |
19 | | - | |
20 | | - | |
21 | | - | |
22 | | - | |
23 | | - | |
24 | | - | |
25 | | - | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
| 20 | + | |
| 21 | + | |
| 22 | + | |
| 23 | + | |
| 24 | + | |
26 | 25 | | |
This file was deleted.
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | 1 | | |
2 | | - | |
| 2 | + | |
3 | 3 | | |
4 | 4 | | |
5 | 5 | | |
6 | 6 | | |
7 | 7 | | |
8 | 8 | | |
9 | | - | |
| 9 | + | |
10 | 10 | | |
11 | 11 | | |
12 | 12 | | |
13 | 13 | | |
14 | 14 | | |
15 | | - | |
16 | | - | |
17 | | - | |
18 | | - | |
19 | | - | |
20 | | - | |
21 | | - | |
22 | | - | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
23 | 20 | | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
4 | 4 | | |
5 | 5 | | |
6 | 6 | | |
7 | | - | |
| 7 | + | |
8 | 8 | | |
9 | 9 | | |
10 | 10 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
4 | 4 | | |
5 | 5 | | |
6 | 6 | | |
7 | | - | |
| 7 | + | |
| 8 | + | |
8 | 9 | | |
9 | | - | |
10 | | - | |
11 | | - | |
12 | | - | |
13 | | - | |
14 | | - | |
15 | | - | |
16 | | - | |
17 | | - | |
18 | | - | |
| 10 | + | |
19 | 11 | | |
This file was deleted.
0 commit comments