Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Background Blur to Input Fields in Edit Popups #5644

Open
Bonapara opened this issue May 29, 2024 · 5 comments · May be fixed by #8277
Open

Add Background Blur to Input Fields in Edit Popups #5644

Bonapara opened this issue May 29, 2024 · 5 comments · May be fixed by #8277
Assignees
Labels
scope: front Issues that are affecting the frontend side only size: short

Comments

@Bonapara
Copy link
Member

Current behavior

Some input fields lack a backdrop filter and have a plain background color.

Current:
CleanShot 2024-05-29 at 10 52 59

Desired:
CleanShot 2024-03-12 at 17 20 10

Desired Behavior

Add the background blur to every field edit popup

backdrop-filter: blur(12px) saturate(200%) contrast(50%) brightness(130%)
background: rgba(252, 252, 252, 0.5)

Fields to update (but do check if I missed any):

  • Calendar field
  • Domain name
  • Address
  • Json
  • Left part of the phone number field

CleanShot 2024-05-29 at 10 50 59

@Bonapara Bonapara added scope: front Issues that are affecting the frontend side only size: short labels May 29, 2024
Copy link
Contributor

greptile-apps bot commented May 29, 2024

Disclaimer: This comment was automatically generated with AI. It can give some useful hints as to where to look for, but sometimes it can also give very inaccurate answers so takes this with a pinch of salt :).

To add the background blur to input fields in edit popups, update the styles in the relevant overlay components. Refer to OverlayBackground.ts for the backdrop filter and background styles. Specifically, add the following CSS to the input fields in the respective components:

backdrop-filter: blur(12px) saturate(200%) contrast(50%) brightness(130%);
background: rgba(252, 252, 252, 0.5);

Update the following components:

  • CalendarField.tsx
  • DomainNameField.tsx
  • AddressField.tsx
  • JsonField.tsx
  • PhoneNumberField.tsx (left part)

References

@shyamsundertard
Copy link
Contributor

shyamsundertard commented Oct 16, 2024

@Bonapara and @charlesBochet I'd like to work on this. Could you assign it to me, please?

@Bonapara
Copy link
Member Author

Sure @shyamsundertard, thanks for contributing!

@charlesBochet
Copy link
Member

@shyamsundertard FYI backdrop filters cannot be superposed in Chrome only one child should set it, this might be the cause of the issue

@shyamsundertard
Copy link
Contributor

@shyamsundertard FYI backdrop filters cannot be superposed in Chrome only one child should set it, this might be the cause of the issue

Ok I'll take care about it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
scope: front Issues that are affecting the frontend side only size: short
Projects
Status: 🔖 Planned
Development

Successfully merging a pull request may close this issue.

3 participants