Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

As a user, when I add an email to a person, in show page, I see timeline "add email event" not properly formatted #8300

Open
martmull opened this issue Nov 4, 2024 · 3 comments
Open

As a user, when I add an email to a person, in show page, I see timeline "add email event" not properly formatted #8300

martmull opened this issue Nov 4, 2024 · 3 comments
Assignees
@yashkhokhar28
Labels
good first issue Good for newcomers scope: backend Issues that are affecting the backend side only type: bug Something isn't working

Comments

@martmull
Copy link
Contributor

martmull commented Nov 4, 2024 •
edited
Loading

Bug Description

  • create a user
  • add an email
  • go to user show page
  • see issue in timeline
    image
  • if i add an aditional email, the additional emails are poorly rendered
    image
image

Expected behavior

No [ ] visible for composite fields

Technical input

  • for composite fields, arrays are returned as strings not as array in FindManyTimelineActivities. In the front, they are expected to be array. We might fix backend so it returns a proper array
image
@martmull martmull added type: bug Something isn't working good first issue Good for newcomers labels Nov 4, 2024
@martmull martmull assigned martmull and unassigned martmull Nov 4, 2024
@Bonapara
Copy link
Member

Bonapara commented Nov 4, 2024

Related to #8264

@yashkhokhar28
Copy link

I would like to work on it.

@Bonapara
Copy link
Member

Bonapara commented Nov 5, 2024

Sure @yashkhokhar28! Please have a look to the related issue. Thanks for contributing!

@martmull martmull added the scope: backend Issues that are affecting the backend side only label Nov 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@yashkhokhar28 yashkhokhar28

Labels
good first issue Good for newcomers scope: backend Issues that are affecting the backend side only type: bug Something isn't working
Projects
Product development ✅
Status: 🆕 New
Milestone
No milestone
Development

No branches or pull requests
3 participants
@Bonapara @martmull @yashkhokhar28