Skip to content

Commit aafb252

Browse files
mbezoyanjenkins
authored and
jenkins
committed
[finagle-memcached] Minor perf optimizations
Removed unnecessary toSeq, also made FrameDecoder an abstract class to avoid more expensive interface calls. Differential Revision: https://phabricator.twitter.biz/D1173582
1 parent 8b74e72 commit aafb252

File tree

2 files changed

+2
-3
lines changed

2 files changed

+2
-3
lines changed

finagle-memcached/src/main/scala/com/twitter/finagle/memcached/protocol/text/FrameDecoder.scala

+1-1
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@ package com.twitter.finagle.memcached.protocol.text
33
import com.twitter.io.Buf
44
import scala.collection.mutable
55

6-
private[memcached] trait FrameDecoder[Result] {
6+
private[memcached] abstract class FrameDecoder[Result] {
77

88
/**
99
* Return the number of raw bytes needed, or -1 if a text line is needed.

finagle-memcached/src/main/scala/com/twitter/finagle/memcached/util/ParserUtils.scala

+1-2
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,7 @@ object ParserUtils {
4444
segmentStart = segmentEnd + 1
4545
}
4646
}
47-
split.toSeq
47+
split
4848
}
4949

5050
/**
@@ -69,5 +69,4 @@ object ParserUtils {
6969
num
7070
}
7171
}
72-
7372
}

0 commit comments

Comments
 (0)